Skip to content

Backport bugfix to 1.1#236

Merged
zhongnansu merged 9 commits intoopensearch-project:1.1from
zhongnansu:1.1.1-zhongnan
Dec 1, 2021
Merged

Backport bugfix to 1.1#236
zhongnansu merged 9 commits intoopensearch-project:1.1from
zhongnansu:1.1.1-zhongnan

Conversation

@zhongnansu
Copy link
Copy Markdown
Member

@zhongnansu zhongnansu commented Dec 1, 2021 •
edited
Loading

Description

prepare for 1.1.1 release

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kroussou and others added 8 commits November 30, 2021 16:56
@kroussou @zhongnansu
Fix quoting and url-encoding (opensearch-project#153)
056559c 
* Replace '%2F' with '/' in relative dates

Signed-off-by: Konstantin Roussou <konstantin.roussou@syncier.com>

* Ensure proper quoting of converted dates in URL

Signed-off-by: Konstantin Roussou <konstantin.roussou@syncier.com>

* Use generic URL decoding

Co-authored-by: Zhongnan Su <szhongna@amazon.com>

* Use roundUp for toDate

Co-authored-by: Zhongnan Su <szhongna@amazon.com>

* Make date transformation same as in context_menu_helpers.js

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
@joshuali925 @zhongnansu
Support range filters for csv reports (opensearch-project#185)
6dfcdc3
@zhongnansu
Forward extra headers while using headless chromium (opensearch-proje…
a6a3722 
…ct#194)
@joshuali925 @zhongnansu
Use advanced settings for date format in csv reports (opensearch-proj…
aa37ec0 
…ect#186)
@zhongnansu
fix csv missing metadata fields issue and empty report on all(_source…
b895cec 
…) fields (opensearch-project#206)
@zhongnansu
refactor logic for creating DSL from saved object using buildOpensear…
4af858b 
…chQuery() (opensearch-project#213)
@joshuali925 @zhongnansu
Use advanced settings for csv separator and visual report timezone (o…
eea2dac 
…pensearch-project#209)
@davidcui1225 @zhongnansu
revert paths to opendistro to keep cluster permissions same with ODFE (…
f26d0c3 
…opensearch-project#218)

Signed-off-by: David Cui <davidcui@amazon.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #236 (4d12e91) into 1.1 (8df7942) will increase coverage by 14.70%.
The diff coverage is 91.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##                1.1     #236       +/-   ##
=============================================
+ Coverage     63.41%   78.12%   +14.70%     
=============================================
  Files           101       33       -68     
  Lines          4401     1929     -2472     
  Branches        669      381      -288     
=============================================
- Hits           2791     1507     -1284     
+ Misses         1442      419     -1023     
+ Partials        168        3      -165
Flag Coverage Δ
dashboards-reports 78.12% <91.66%> (+2.10%) ⬆️
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ards-reports/public/components/main/main_utils.tsx 76.53% <ø> (ø)
...eports/public/components/utils/settings_service.ts 76.92% <76.92%> (ø)
...s-reports/server/routes/utils/dataReportHelpers.ts 92.70% <93.75%> (+30.20%) ⬆️
.../components/main/report_details/report_details.tsx 73.73% <100.00%> (ø)
...ashboards-reports/server/routes/utils/constants.ts 100.00% <100.00%> (ø)
...rts/server/routes/utils/savedSearchReportHelper.ts 98.75% <100.00%> (-0.06%) ⬇️
...r/routes/utils/visual_report/visualReportHelper.ts 88.75% <100.00%> (+4.22%) ⬆️
...tsscheduler/action/CreateReportDefinitionAction.kt
...sscheduler/action/GetAllReportDefinitionsAction.kt
...rtsscheduler/action/GetAllReportInstancesAction.kt
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df7942...4d12e91. Read the comment docs.

@zhongnansu zhongnansu force-pushed the 1.1.1-zhongnan branch 2 times, most recently from 276bf5e to 7b352b6 Compare December 1, 2021 07:34
@zhongnansu zhongnansu marked this pull request as ready for review December 1, 2021 19:31
@zhongnansu zhongnansu self-assigned this Dec 1, 2021
@zhongnansu zhongnansu merged commit 9e82779 into opensearch-project:1.1 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@anirudha anirudha Awaiting requested review from anirudha

@kavithacm kavithacm Awaiting requested review from kavithacm

1 more reviewer

@davidcui1225 davidcui1225 davidcui1225 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhongnansu zhongnansu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhongnansu @codecov-commenter @joshuali925 @davidcui1225 @kroussou