Fix snapshot build and upgrade to OpenSearch 1.1.#139
Closed
dblock wants to merge 2 commits intoopensearch-project:mainfrom
Closed
Fix snapshot build and upgrade to OpenSearch 1.1.#139dblock wants to merge 2 commits intoopensearch-project:mainfrom
dblock wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
=============================================
+ Coverage 62.42% 73.30% +10.87%
=============================================
Files 101 32 -69
Lines 4484 2030 -2454
Branches 681 404 -277
=============================================
- Hits 2799 1488 -1311
+ Misses 1517 539 -978
+ Partials 168 3 -165
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: dblock <dblock@amazon.com>
9e0848a to
d8d9c6e
Compare
Signed-off-by: dblock <dblock@amazon.com>
14 tasks
zhongnansu
suggested changes
Aug 18, 2021
Member
zhongnansu
left a comment
There was a problem hiding this comment.
I think we shouldn't remove the job-scheduler zip in test/resources. Even tho the CI can pass since you modify the workflow to build and add the job-scheduler artifact to the test resources, the local build will still fail
1 task
Member
Author
|
Don't want to lose a branch with this code, so replaced this PR with #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Fixes and defaults to snapshot build. Requires OpenSearch 1.1.
Issues Resolved
Closes #138.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.