Exclude time range check in report details for notebooks reports#116
Closed
davidcui1225 wants to merge 1 commit intomainfrom
Closed
Exclude time range check in report details for notebooks reports#116davidcui1225 wants to merge 1 commit intomainfrom
davidcui1225 wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
approved these changes
Jul 8, 2021
Member
joshuali925
left a comment
There was a problem hiding this comment.
is there a more precise identifier other than notebooks-dashboards string? if not it's fine
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 63.40% 63.41%
Complexity 309 309
=========================================
Files 101 101
Lines 4400 4401 +1
Branches 668 669 +1
=========================================
+ Hits 2790 2791 +1
Misses 1442 1442
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
Yes I'll replace it with checking |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Cui davidcui@amazon.com
Description
Exclude checking time range for notebooks report details
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.