Conversation
|
This looks good to me! |
VachaShah
left a comment
There was a problem hiding this comment.
This looks great! And solves all the problems we have related to tags.
I think we can also mention as a note for the users (in a separate PR) that there are going to be no new versions of the other gems since they are being combined into one. Similar to how we have for dsl-py.
|
It's basically complete. Just waiting for https://github.com/opensearch-project/opensearch-ruby-aws-sigv4 to go public so the link checker workflow would pass. Will also have a summary of what was done. |
- Removed sigv4 gem since it's already been moved to https://github.com/opensearch-project/opensearch-ruby-aws-sigv4 - Merged Lib files of the remaining 4 gems - Merged Test and Spec files (With refactoring to the helper modules) - Reworked all rake tasks: - Redid all Test tasks to fit single-gem-multi-module structure - Redid RDOC task to work with 1 gem instead of multiple - Removed unused tasks - Updated all workflow to work with single-gem structure - Added CHANGELOG.md and change_log workflow - Fixed all rubocop infractions in `./lib/**/*` - Updated all docs accordingly - Cleaned up and reworked gemspec and gemfile - Updated `build.sh` to work with single-gem structure. - Reworked opensearch_ruby_console. Signed-off-by: Theo Truong <theotr@amazon.com>
|
This is ready for review. I've updated the description with all overview of what was done. Basically only one or two files were untouched while the rest were moved or modified 😅. So, take your time. |
| rake test:api:unit | ||
| rake test:transport:unit | ||
| rake test:dsl:unit | ||
| rake test:client:unit |
| end | ||
|
|
||
| desc 'Run API tests' | ||
| task :all do |
There was a problem hiding this comment.
Generally you can do task name: [:prereq1, :prereq2] .
|
Looks great, merge it! |
Description
./lib/**/*build.shto work with single-gem structure.Issues Resolved
Closes #133
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.