Replace single changelog with one for each gem.#127
Merged
nhtruong merged 1 commit intoopensearch-project:mainfrom Jan 9, 2023
nhtruong:remove_changelog
Merged
Replace single changelog with one for each gem.#127nhtruong merged 1 commit intoopensearch-project:mainfrom nhtruong:remove_changelog
nhtruong merged 1 commit intoopensearch-project:mainfrom
nhtruong:remove_changelog
Conversation
Member
|
But now we won't know what changed! What's the long term fix? I imagine we can combine the gems or have a CHANGELOG in each? |
Collaborator
Author
|
@dblock The commit messages will serve this purpose. Whenever you draft a new release, Github will pull the info of all commits since the last release for you to edit. With 5 gems, each with its own version number, the long term solution is having a Changelog for each gem. It's the automated enforcement of changelog that's giving us trouble because it only works for 1 changelog file per repo. For now we're going to ask people to update the appropriate changelog when they offer a PR. |
Collaborator
|
@nhtruong I don't think we need the |
harshavamsi
previously approved these changes
Dec 19, 2022
Member
|
LGTM, needs a rebase |
With multiple gems coexisting in the same repo, the current framework for CHANGELOG.md is not suitable. We're going with a changelog for each gem and disable changelog verifier since it can't handle multiple change logs yet. Signed-off-by: Theo Truong <theotr@amazon.com>
harshavamsi
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With multiple gems coexisting in the same repo, the current framework for CHANGELOG.md is not suitable. We're going with a changelog for each gem and disable changelog verifier since it can't handle multiple change logs yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.