Codecov Report

Merging #1863 (de9a7f1) into main (14bbb60) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1863   +/-   ##
=========================================
  Coverage     94.46%   94.46%           
  Complexity       22       22           
=========================================
  Files           179      179           
  Lines          3649     3649           
  Branches         29       29           
=========================================
  Hits           3447     3447           
  Misses          196      196           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bbb60...de9a7f1. Read the comment docs.

This is a big change means a lot of the repos needs to change their ci as well. Will block this until we clear up the confusion and final decision.

Thanks.

We will merge this PR once we have the working build with alpha qualifier.

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

So just to confirm you will send PR to all the plugin repos to change alpha1 to rc1 after build success, right?
Thanks.

This is only for the build repo manifest, as all other plugin repos all need to change their default to rc1.

Once this is merged, the rc1 value will be passed through to plugin builds and used via -Dopensearch... options. It will produce a -SNAPSHOT build of OpenSearch-min which then can be used to update the plugin CI. I will take care of it.

So just to confirm you will send PR to all the plugin repos to change alpha1 to rc1 after build success, right? Thanks.

Yes, that's what I am saying.

I saw @kavilla also made this change for OSD in #1949. Do you want me to update this to just do OpenSearch?

I saw @kavilla also made this change for OSD in #1949. Do you want me to update this to just do OpenSearch?

We will fix the alpha1 build to be green before switch to rc1.

@peterzhuamazon We have to merge this and ensure at least 1 successful RC1 SNAPSHOT build before we go PR changes in all plugins, otherwise their CIs will start failing because there's no opensearch-min-SNAPSHOT.

@dblock I approve.