Remove invalid cardinality aggregation hints.#970
Merged
karenyrx merged 2 commits intoopensearch-project:mainfrom Sep 30, 2025
Merged
Remove invalid cardinality aggregation hints.#970karenyrx merged 2 commits intoopensearch-project:mainfrom
karenyrx merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Contributor
Changes AnalysisCommit SHA: 8e325b2 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/18111530457/artifacts/4137240460 API Coverage
|
Contributor
Spec Test Coverage Analysis
|
lucy66hw
approved these changes
Sep 29, 2025
karenyrx
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
save_memory_heuristic,save_time_heuristic,segment_ordinalsare unused execution hints for cardinality aggregation. Only direct and global ordinals are valid:https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregatorFactory.java#L62-L80
It seems the others may have been pulled from ES documentation:
https://www.elastic.co/docs/reference/aggregations/search-aggregations-metrics-cardinality-aggregation#_pre_computed_hashes
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.