[Pull-based Ingestion] Update params value type in ingestion source#945
Merged
Xtansia merged 1 commit intoopensearch-project:mainfrom Aug 6, 2025
Merged
Conversation
Contributor
Changes AnalysisCommit SHA: 4ee3317 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/16662075313/artifacts/3662990579 API Coverage
|
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
1e3d09f to
4ee3317
Compare
Contributor
Spec Test Coverage Analysis
|
andrross
approved these changes
Aug 6, 2025
Member
|
@harshavamsi Can we get a quick review on this PR? There are some broken links unrelated to this PR causing the check links workflow to fail. If possible it'd be nice to merge this and follow up separately with a fix to the links. |
Xtansia
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ingestion source setting in pull-based ingestion contains a "params" Map<String, Object>. However, api-spec defines this as Map<String, String>. Correct the api-spec to take in any type. Note: pull-based ingestion is an experimental feature.
Issues Resolved
Follow up for #908
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.