Skip to content

Add ML Controller APIs#779

Merged
dblock merged 3 commits intoopensearch-project:mainfrom
nathaliellenaa:add-ml-controller-api
Jan 13, 2025
Merged

Add ML Controller APIs#779
dblock merged 3 commits intoopensearch-project:mainfrom
nathaliellenaa:add-ml-controller-api

Conversation

@nathaliellenaa
Copy link
Copy Markdown
Contributor

@nathaliellenaa nathaliellenaa commented Jan 10, 2025 •
edited
Loading

Description

Added missing ML Controller APIs.

Issues Resolved

Part of opensearch-project/opensearch-py#867.

ML Controller APIs to add

  • POST /_plugins/_ml/controllers/{model_id}
  • PUT /_plugins/_ml/controllers/{model_id}
  • GET /_plugins/_ml/controllers/{model_id}
  • DELETE /_plugins/_ml/controllers/{model_id}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Changes Analysis

Commit SHA: ba3731d
Comparing To SHA: 9efddb9

API Changes

Summary

├─┬Paths
│ └──[➕] path (4817:3)
└─┬Components
  ├──[➕] requestBodies (27974:7)
  ├──[➕] requestBodies (28408:7)
  ├──[➕] responses (31626:7)
  ├──[➕] responses (31509:7)
  ├──[➕] responses (31568:7)
  ├──[➕] responses (31814:7)
  ├──[➕] parameters (23614:7)
  ├──[➕] parameters (23722:7)
  ├──[➕] parameters (23572:7)
  ├──[➕] parameters (23548:7)
  ├──[➕] schemas (56522:7)
  └──[➕] schemas (56541:7)
Document Element Total Changes Breaking Changes
paths 1 0
components 12 0
  • Total Changes: 13
  • Additions: 13

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12753323257/artifacts/2423831430

API Coverage

Before After Δ
Covered (%) 643 (62.98 %) 647 (63.37 %) 4 (0.39 %)
Uncovered (%) 378 (37.02 %) 374 (36.63 %) -4 (-0.39 %)
Unknown 43 43 0

@dblock
Copy link
Copy Markdown
Member

dblock commented Jan 10, 2025

Looks like there's a test failure, otherwise LGTM.

@nathaliellenaa
Copy link
Copy Markdown
Contributor Author

nathaliellenaa commented Jan 10, 2025

Looks like the failing test is due to the Memory Circuit Breaker flaky error https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12701647488/artifacts/2410641526. I made a fix for this issue in this PR and I can rerun the test once this PR has been merged.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jan 10, 2025

Looks like the failing test is due to the Memory Circuit Breaker flaky error https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12701647488/artifacts/2410641526. I made a fix for this issue in this PR and I can rerun the test once this PR has been merged.

Merged, rebase?

@nathaliellenaa
Added ML create, update, get, delete controller APIs.
c582f31 
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@nathaliellenaa
Added memory threshold settings in Controller API tests.
aa51ade 
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Spec Test Coverage Analysis

Total Tested
577 576 (99.83 %)

dblock
dblock suggested changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs folder got folded in, remove and add it to .gitignore?

Also check test coverage? We were at 100, we lost something.

@nathaliellenaa
Copy link
Copy Markdown
Contributor Author

nathaliellenaa commented Jan 10, 2025 •
edited
Loading

Also check test coverage? We were at 100, we lost something.

I see that the test coverage is lost from this PR. Seems that the PR removed the test for POST /_search_shards and POST /{index}/_search_shards, but the specs for the APIs are still there.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jan 11, 2025

@Xtansia

@dblock dblock mentioned this pull request Jan 11, 2025
Merged
@nathaliellenaa
Remove logs folder and add it to .gitignore.
ba3731d 
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@dblock dblock merged commit 0d63cdb into opensearch-project:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nathaliellenaa @dblock