Skip to content

Added support for multiple test verbs.#724

Merged
nhtruong merged 4 commits intoopensearch-project:mainfrom
dblock:multiple-verb-chapters
Dec 11, 2024
Merged

Added support for multiple test verbs.#724
nhtruong merged 4 commits intoopensearch-project:mainfrom
dblock:multiple-verb-chapters

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Dec 10, 2024 •
edited
Loading

Description

Alternative to #723.

You can now do this:

- synopsis: Use POST and PUT interchangeably.
  path: /{index}
  method:
    - POST
    - PUT

Avoids duplicating the test.

Added tests and fixed /_render/template.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Added support for multiple test verbs.
5024aec 
Signed-off-by: dblock <dblock@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2024 •
edited
Loading

Changes Analysis

Commit SHA: 41446b8
Comparing To SHA: 6341e87

API Changes

Summary

└─┬Paths
  ├─┬/_render/template/{id}
  │ ├─┬GET
  │ │ └─┬Requestbody
  │ │   └─┬application/json
  │ │     └─┬Schema
  │ │       ├──[➕] properties (27315:15)
  │ │       ├──[➖] properties (27315:15)❌ 
  │ │       └─┬params
  │ │         └──[🔀] additionalProperties (27323:39)❌ 
  │ └─┬POST
  │   └─┬Requestbody
  │     └─┬application/json
  │       └─┬Schema
  │         ├──[➕] properties (27315:15)
  │         ├──[➖] properties (27315:15)❌ 
  │         └─┬params
  │           └──[🔀] additionalProperties (27323:39)❌ 
  └─┬/_render/template
    ├─┬GET
    │ └─┬Requestbody
    │   └─┬application/json
    │     └─┬Schema
    │       ├──[➕] properties (27315:15)
    │       ├──[➖] properties (27315:15)❌ 
    │       └─┬params
    │         └──[🔀] additionalProperties (27323:39)❌ 
    └─┬POST
      └─┬Requestbody
        └─┬application/json
          └─┬Schema
            ├──[➕] properties (27315:15)
            ├──[➖] properties (27315:15)❌ 
            └─┬params
              └──[🔀] additionalProperties (27323:39)❌
Document Element Total Changes Breaking Changes
paths 12 8
  • ❌ BREAKING Changes: 8 out of 12
  • Modifications: 4
  • Removals: 4
  • Additions: 4
  • Breaking Removals: 4
  • Breaking Modifications: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12280552975/artifacts/2306872997

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2024

Spec Test Coverage Analysis

Total Tested
536 475 (88.62 %)

@dblock dblock force-pushed the multiple-verb-chapters branch 2 times, most recently from 22d446d to 6327d3d Compare December 11, 2024 13:31
@dblock
Use strong types for parsed stories.
05a81a8 
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the multiple-verb-chapters branch from 6327d3d to 05a81a8 Compare December 11, 2024 13:33
@dblock dblock mentioned this pull request Dec 11, 2024
Closed
@dblock dblock marked this pull request as ready for review December 11, 2024 13:35
nhtruong
nhtruong previously approved these changes Dec 11, 2024
View reviewed changes
Comment thread tools/src/tester/StoryParser.ts Outdated
Comment thread tools/src/tester/StoryParser.ts
@dblock
Do not allow multiple methods in prologues or epilogues.
92c2bd4 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Display verb when expanding chapters.
41446b8 
Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 01f222e into opensearch-project:main Dec 11, 2024
@dblock dblock deleted the multiple-verb-chapters branch December 11, 2024 19:36
@dblock dblock mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

1 more reviewer

@nhtruong nhtruong nhtruong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dblock @nhtruong