Skip to content

Index Search Template API tests#702

Merged
dblock merged 4 commits intoopensearch-project:mainfrom
Tokesh:template-tests
Dec 2, 2024
Merged

Index Search Template API tests#702
dblock merged 4 commits intoopensearch-project:mainfrom
Tokesh:template-tests

Conversation

@Tokesh
Copy link
Copy Markdown
Collaborator

@Tokesh Tokesh commented Dec 1, 2024

Description

test for:
GET /{index}/_search/template
POST /{index}/_search/template
GET /_search/template
POST /_search/template

Issues Resolved

[#663]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Tokesh
adding tests for search templates
c34aaec 
Signed-off-by: Tokesh <tokesh789@gmail.com>
@Tokesh Tokesh changed the title adding tests for search templates Index Search Template API tests Dec 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2024 •
edited
Loading

Changes Analysis

Commit SHA: c8f5b15
Comparing To SHA: c400057

API Changes

Summary

└─┬Paths
  ├─┬/{index}/_search/template
  │ ├─┬GET
  │ │ └─┬Responses
  │ │   └─┬200
  │ │     └─┬application/json
  │ │       └─┬Schema
  │ │         └──[➕] properties (30447:15)
  │ └─┬POST
  │   └─┬Responses
  │     └─┬200
  │       └─┬application/json
  │         └─┬Schema
  │           └──[➕] properties (30447:15)
  └─┬/_search/template
    ├─┬GET
    │ └─┬Responses
    │   └─┬200
    │     └─┬application/json
    │       └─┬Schema
    │         └──[➕] properties (30447:15)
    └─┬POST
      └─┬Responses
        └─┬200
          └─┬application/json
            └─┬Schema
              └──[➕] properties (30447:15)
Document Element Total Changes Breaking Changes
paths 4 0
  • Total Changes: 4
  • Additions: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12124975377/artifacts/2262992706

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

@Tokesh Tokesh added the skip-changelog No need to update CHANGELOG. label Dec 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 1, 2024 •
edited
Loading

Spec Test Coverage Analysis

Total Tested
528 419 (79.36 %)

@Tokesh Tokesh marked this pull request as ready for review December 1, 2024 08:52
@dblock dblock removed the skip-changelog No need to update CHANGELOG. label Dec 1, 2024
dblock
dblock suggested changes Dec 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do add to CHANGELOG.

@Tokesh
adding changelog log
2e6464a 
Signed-off-by: Tokesh <tokesh789@gmail.com>
@Tokesh Tokesh requested a review from dblock December 2, 2024 16:38
@Tokesh
Copy link
Copy Markdown
Collaborator Author

Tokesh commented Dec 2, 2024 •
edited
Loading

@dblock Thank you! ready for your review!

dblock
dblock suggested changes Dec 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be annoying. Let's put these tests in the right place?

/{index}/_search/template -> tests/default/indices/search/template.yaml
/_search/template -> tests/default/search/template.yaml

Tokesh added 2 commits December 2, 2024 22:19
@Tokesh
renamed and moved to another more specific folders
0778647 
Signed-off-by: Tokesh <tokesh789@gmail.com>
@Tokesh
not correct path to root test story
c8f5b15 
Signed-off-by: Tokesh <tokesh789@gmail.com>
@Tokesh
Copy link
Copy Markdown
Collaborator Author

Tokesh commented Dec 2, 2024 •
edited
Loading

Sorry to be annoying. Let's put these tests in the right place?

/{index}/_search/template -> tests/default/indices/search/template.yaml /_search/template -> tests/default/search/template.yaml

It doesn't annoy! Thank you

@Tokesh Tokesh requested a review from dblock December 2, 2024 17:47
@dblock dblock merged commit d3c8d65 into opensearch-project:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tokesh @dblock