Skip to content

Misc fixes and tests.#673

Merged
Xtansia merged 6 commits intoopensearch-project:mainfrom
dblock:more-tests
Nov 18, 2024
Merged

Misc fixes and tests.#673
Xtansia merged 6 commits intoopensearch-project:mainfrom
dblock:more-tests

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Nov 14, 2024 •
edited
Loading

Description

  • Added GET and HEAD /{index}/_source/{id} returning 404.
  • Added tests for GET /{index}/_refresh.
  • Added tests for POST /{index}/_mget.
  • Fixed all refresh options to allow boolean and string.
  • Added tests for POST /{index}/_update/{id}.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Changes Analysis

Commit SHA: 0c8b3b8
Comparing To SHA: bf35601

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_bulk
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_bulk/stream
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_update/{id}
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_bulk/stream
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_reindex
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_create/{id}
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_delete_by_query
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/_bulk
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_doc/{id}
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ ├─┬POST
│ │ │ └──Parameters
│ │ ├─┬DELETE
│ │ │ └──Parameters
│ │ └─┬HEAD
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_source/{id}
│ │ ├─┬GET
│ │ │ ├─┬Parameters
│ │ │ │ └─┬Schema
│ │ │ │   └──[🔀] $ref (32493:9)❌ 
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (28552:7)
│ │ └─┬HEAD
│ │   ├─┬Parameters
│ │   │ └─┬Schema
│ │   │   └──[🔀] $ref (32493:9)❌ 
│ │   └─┬Responses
│ │     └──[➕] codes (28206:7)
│ ├─┬/{index}/_mget
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/_mget
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_doc
│ │ └─┬POST
│ │   └──Parameters
│ └─┬/{index}/_update_by_query
│   └─┬POST
│     └─┬Parameters
│       └─┬Schema
│         └──[🔀] $ref (32493:9)❌ 
└─┬Components
  ├──[➕] responses (28206:7)
  ├──[➕] responses (28552:7)
  └─┬_common___Refresh
    ├──[➖] enum (32480:11)❌ 
    ├──[➖] enum (32481:11)❌ 
    ├──[➖] enum (32482:11)❌ 
    ├──[➖] type (32478:13)❌ 
    ├──[➕] oneOf (32494:11)
    └──[➕] oneOf (32493:11)
Document Element Total Changes Breaking Changes
paths 13 11
components 8 4
  • ❌ BREAKING Changes: 15 out of 21
  • Modifications: 11
  • Removals: 4
  • Additions: 6
  • Breaking Removals: 4
  • Breaking Modifications: 11

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11893676849/artifacts/2201639107

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 42 42 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Spec Test Coverage Analysis

Total Tested
517 358 (69.25 %)

@dblock dblock changed the title Added GET and HEAD /{index}/_source/{id} returning 404 + more tests. Misc fixes and tests. Nov 14, 2024
@dblock dblock marked this pull request as ready for review November 14, 2024 20:07
@dblock
Added test for GET /{index}/_refresh.
0528810 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Added and returning .
d102f52 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Added tests for POST /{index}/_mget.
4f479ac 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Fixed all refresh options to allow boolean and string.
8903287 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Added tests for POST /_msearch.
dd5aba3 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Added tests for PUT /_bulk/stream.
0c8b3b8 
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Nov 18, 2024

@Xtansia @nhtruong please?

@Xtansia Xtansia merged commit 4c1ea37 into opensearch-project:main Nov 18, 2024
@dblock dblock deleted the more-tests branch November 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xtansia Xtansia Xtansia approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dblock @Xtansia