Add support for application/smile#386
Merged
Xtansia merged 1 commit intoopensearch-project:mainfrom Jul 10, 2024
Merged
Conversation
Contributor
Changes AnalysisCommit SHA: ab88a52 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9865817894/artifacts/1684368883 API Coverage
|
Xtansia
requested changes
Jul 9, 2024
Comment on lines
+89
to
+92
| format: smile | ||
| response: | ||
| status: 200 | ||
| content_type: application/yaml |
Collaborator
There was a problem hiding this comment.
Are we not actually validating content_type against the response content-type header?
Comment on lines
+47
to
+54
| - synopsis: This GET /_cat/health chapter returns application/smile and should pass. | ||
| path: /_cat/health | ||
| parameters: | ||
| format: cbor | ||
| method: GET | ||
| response: | ||
| status: 200 | ||
| content_type: application/smile |
Collaborator
There was a problem hiding this comment.
As above regarding validating content_type as test is supposed to be for smile but format is set to cbor
Member
Author
There was a problem hiding this comment.
Updated to be format: smile.
Signed-off-by: dblock <dblock@amazon.com>
Xtansia
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for application/smile.
Thanks to @ngyewch for the recent work on the smile-js library to get this over the line!
Issues Resolved
Closes #372.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.