Skip to content

Added cancel_after_time_interval and phase_took in _search.#353

Merged
Xtansia merged 2 commits intoopensearch-project:mainfrom
dblock:fix-273
Jun 24, 2024
Merged

Added cancel_after_time_interval and phase_took in _search.#353
Xtansia merged 2 commits intoopensearch-project:mainfrom
dblock:fix-273

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Jun 21, 2024

Description

Added support for cancel_after_time_interval and phase_took in _search.

Issues Resolved

Closes #273.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Added tests for basic _search.
fd1f31c 
Signed-off-by: dblock <dblock@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

Changes Analysis

Commit SHA: 0f7ddc1
Comparing To SHA: 33aa91a

API Changes

Summary

├─┬Paths
│ ├─┬/_search
│ │ ├─┬GET
│ │ │ ├──[➕] parameters (19919:13)❌ 
│ │ │ └──[➕] parameters (20030:13)❌ 
│ │ └─┬POST
│ │   ├──[➕] parameters (19919:13)❌ 
│ │   └──[➕] parameters (20030:13)❌ 
│ └─┬/{index}/_search
│   ├─┬GET
│   │ ├──[➕] parameters (19919:13)❌ 
│   │ └──[➕] parameters (20030:13)❌ 
│   └─┬POST
│     ├──[➕] parameters (20030:13)❌ 
│     └──[➕] parameters (19919:13)❌ 
└─┬Components
  ├──[➕] parameters (19918:7)
  ├──[➕] parameters (20030:7)
  ├──[➕] schemas (26858:7)
  └─┬_core.search:ResponseBody
    └──[➕] properties (37922:9)
Document Element Total Changes Breaking Changes
components 4 0
paths 8 8
  • ❌ BREAKING Changes: 8 out of 12
  • Additions: 12
  • Breaking Additions: 8

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9614175917/artifacts/1624832311

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock changed the title Added support for cancel_after_time_interval and phase_took in _search. Added cancel_after_time_interval and phase_took in _search. Jun 21, 2024
@dblock dblock mentioned this pull request Jun 21, 2024
Closed
@Xtansia Xtansia merged commit 6e4c7ba into opensearch-project:main Jun 24, 2024
@dblock dblock deleted the fix-273 branch June 24, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xtansia Xtansia Xtansia approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for cancel_after_time_interval

2 participants

@dblock @Xtansia