Adds API spec for security plugin by DarshitChanpura · Pull Request #271 · opensearch-project/opensearch-api-specification

DarshitChanpura · 2024-04-24T22:24:00Z

Description

Corrects invalid entries and adds missing entries for the security plugin.

Issues Resolved

Resolves [FEATURE] Add specs for security namespace #233

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

dblock

Go through descriptions and ensure common format (missing periods at the end of sentences).

Is this ready, mark it ready for review?

spec/schemas/security._common.yaml

spec/namespaces/security.yaml

DarshitChanpura · 2024-04-29T15:51:49Z

@dblock ty for your review. This isn't ready yet. I'm doing a final pass-through the spec file to validate grammar and previously added specs. I'll mark it as ready once all changes are complete.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-04-30T17:49:58Z

API specs implemented for 293/649 (45%) APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-01T15:24:01Z

API specs implemented for 299/649 (46%) APIs.

github-actions · 2024-05-01T15:24:09Z

API specs implemented for 299/649 (46%) APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-01T15:30:26Z

API specs implemented for 299/649 (46%) APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-01T15:34:43Z

API specs implemented for 299/649 (46%) APIs.

DarshitChanpura · 2024-05-01T15:53:24Z

@dblock @nhtruong This PR is ready for review.

QQ, how are we planning to test the validity of all the added specs?

DarshitChanpura · 2024-05-01T15:56:35Z

A new endpoint is in the process of being added to security plugin. I will update the spec once the PR is merged in security repo: opensearch-project/security#4299

dblock · 2024-05-01T16:51:26Z

@dblock @nhtruong This PR is ready for review.

QQ, how are we planning to test the validity of all the added specs?

It's time for an issue!

#277

We do have a lot of tests in clients but we should add something here that exercises APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-02T15:54:46Z

API specs implemented for 299/649 (46%) APIs.

spec/schemas/security._common.yaml

spec/_superseded_operations.yaml

spec/namespaces/security.yaml

spec/schemas/security._common.yaml

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-07T14:55:32Z

API specs implemented for 299/649 (46%) APIs.

…ibility Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

github-actions · 2024-05-08T15:48:14Z

API specs implemented for 299/649 (46%) APIs.

nhtruong · 2024-05-09T15:14:19Z

@Xtansia This looks good to me but would love a 2nd pair of eyes to review this.

Xtansia

LGTM

dblock · 2024-06-04T13:50:20Z

@DarshitChanpura We have a new test framework in added in #299, maybe you'll be interested in writing tests for the security plugin using it?

DarshitChanpura · 2024-06-04T16:37:47Z

@DarshitChanpura We have a new test framework in added in #299, maybe you'll be interested in writing tests for the security plugin using it?

Yes, I'll take a stab at it.

Adds missing entries in the spec as well superseded yml files

6c77e05

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

dblock mentioned this pull request Apr 25, 2024

[FEATURE] Check order of methods in spec #272

Closed

DarshitChanpura added 3 commits April 25, 2024 12:16

Re-organized HTTP methods in GET, POST, PUT, PATCH, DELETE order

3ef5417

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Re-arrange alphabetically

d19d816

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Added all missing endpoints

d736dc7

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

dblock reviewed Apr 29, 2024

View reviewed changes

spec/schemas/security._common.yaml Outdated Show resolved Hide resolved

spec/namespaces/security.yaml Outdated Show resolved Hide resolved

DarshitChanpura added 4 commits April 29, 2024 18:40

Added missing response codes

415c990

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Merge remote-tracking branch 'upstream/main' into security-api-spec

f5b8fbb

Adds correct versions and fixes grammar in description field

fc988d9

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Adds entries in root file and fixes linter

95a6758

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

DarshitChanpura marked this pull request as ready for review May 1, 2024 15:03

DarshitChanpura requested review from VachaShah, Xtansia, harshavamsi, nhtruong, pgtgrly and sachetalva as code owners May 1, 2024 15:03

DarshitChanpura added 2 commits May 1, 2024 11:22

Adds legacy user api and rearranges some request bodies

288a711

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Merge remote-tracking branch 'upstream/main' into security-api-spec

bd7fab4

Re-arranges some more schemas

d1ba464

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Fixes a couple of descriptions

13360e2

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

dblock mentioned this pull request May 1, 2024

[PROPOSAL] Add integration tests #277

Closed

DarshitChanpura added 2 commits May 2, 2024 11:50

Sort all schemas alphabetically

a1dd8e1

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Merge remote-tracking branch 'upstream/main' into security-api-spec

5b15dae

nhtruong reviewed May 3, 2024

View reviewed changes

spec/schemas/security._common.yaml Show resolved Hide resolved

nhtruong reviewed May 6, 2024

View reviewed changes

spec/_superseded_operations.yaml Show resolved Hide resolved

nhtruong reviewed May 6, 2024

View reviewed changes

spec/namespaces/security.yaml Show resolved Hide resolved

nhtruong reviewed May 6, 2024

View reviewed changes

spec/namespaces/security.yaml Show resolved Hide resolved

nhtruong reviewed May 6, 2024

View reviewed changes

spec/schemas/security._common.yaml Outdated Show resolved Hide resolved

DarshitChanpura added 2 commits May 7, 2024 10:53

Make cache operation ingorable

939654a

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Merge remote-tracking branch 'upstream/main' into security-api-spec

8d4ecdf

Replace properties with additionalProperties for readability and flex…

a50b711

…ibility Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

nhtruong approved these changes May 9, 2024

View reviewed changes

Xtansia approved these changes May 10, 2024

View reviewed changes

Xtansia merged commit de939d2 into opensearch-project:main May 10, 2024

dblock mentioned this pull request Jun 3, 2024

[FEATURE] Add missing API specs #168

Open

DarshitChanpura mentioned this pull request Jun 5, 2024

Add tests for the new API spec opensearch-project/security#4404

Closed

Conversation

DarshitChanpura commented Apr 24, 2024

Description

Issues Resolved

Uh oh!

dblock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DarshitChanpura commented Apr 29, 2024

Uh oh!

github-actions bot commented Apr 30, 2024

Uh oh!

github-actions bot commented May 1, 2024

Uh oh!

github-actions bot commented May 1, 2024

Uh oh!

github-actions bot commented May 1, 2024

Uh oh!

github-actions bot commented May 1, 2024

Uh oh!

DarshitChanpura commented May 1, 2024

Uh oh!

DarshitChanpura commented May 1, 2024

Uh oh!

dblock commented May 1, 2024

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 7, 2024

Uh oh!

github-actions bot commented May 8, 2024

Uh oh!

nhtruong commented May 9, 2024

Uh oh!

Xtansia left a comment

Choose a reason for hiding this comment

Uh oh!

dblock commented Jun 4, 2024

Uh oh!

DarshitChanpura commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants