Fix AggregationContainer for all bucket aggregations so that aggs/aggregations are siblings of the aggregation type#1069
Merged
lucy66hw merged 3 commits intoopensearch-project:mainfrom Mar 12, 2026
Conversation
…/`aggregations` are siblings of the aggregation type Signed-off-by: Karen X <karenxyr@gmail.com>
Contributor
Proto Compatibility ReportMerge ReportNo changes detected. Generated by Proto Compatibility Check |
Contributor
Changes AnalysisCommit SHA: 43a4c4e API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/22982009615/artifacts/5882563013 API Coverage
|
lucy66hw
reviewed
Mar 11, 2026
| $ref: '#/components/schemas/AutoDateHistogramAggregation' | ||
| required: [auto_date_histogram] | ||
| unevaluatedProperties: true | ||
| - $ref: '#/components/schemas/AdjacencyMatrixAggregation' |
Collaborator
There was a problem hiding this comment.
will properties: adjacency_matrix lost by this change?
Collaborator
Author
There was a problem hiding this comment.
no, adjacency_matrix is now defined in AdjacencyMatrixAggregation
AdjacencyMatrixAggregation:
allOf:
- $ref: '#/components/schemas/BucketAggregationBase'
- type: object
properties:
adjacency_matrix:
type: object
properties:
filters:
description: |-
Filters used to create buckets.
At least one filter is required.
type: object
additionalProperties:
$ref: '_common.query_dsl.yaml#/components/schemas/QueryContainer'
required: [adjacency_matrix]
Signed-off-by: Karen X <karenxyr@gmail.com>
This reverts commit 63bb8f5. Signed-off-by: Karen X <karenxyr@gmail.com>
lucy66hw
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The correct REST request format is:
but current spec supports something like this instead ("aggs" is incorrectly nested inside "terms")
Fix this for 26 aggregation types that have a base of BucketAggregationBase (which is where subaggregations live)
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.