Skip to content

Fix partition field formats and remove protobuf exclusion in aggregat…#1065

Merged
karenyrx merged 1 commit intoopensearch-project:mainfrom
yiyuabc:fix-aggregations-schema-format
Mar 6, 2026
Merged

Fix partition field formats and remove protobuf exclusion in aggregat…#1065
karenyrx merged 1 commit intoopensearch-project:mainfrom
yiyuabc:fix-aggregations-schema-format

Conversation

@yiyuabc
Copy link
Copy Markdown
Contributor

@yiyuabc yiyuabc commented Mar 6, 2026

…ions schema

  • Change num_partitions and partition fields from int64 to int32 format because REST code IncludeExclude.java uses integer
  • Remove x-protobuf-excluded flag from order field in aggregation schema

Description

Describe what this change achieves.

Screenshot 2026-03-06 at 2 59 12 PM Screenshot 2026-03-06 at 2 59 21 PM Screenshot 2026-03-06 at 2 59 59 PM

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Proto Compatibility Report

Merge Report

No changes detected.


Generated by Proto Compatibility Check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Changes Analysis

Commit SHA: f5a2b3d
Comparing To SHA: 12f0812

API Changes

Summary

└─┬Components
  └─┬Schemas
    └─┬_common.aggregations___TermsPartition
      └─┬Properties
        ├─┬partition
        │ └──[🔀] format (44712:19)❌ 
        └─┬num_partitions
          └──[🔀] format (44708:19)❌ 

Document Element Total Changes Breaking Changes
components 2 2
  • BREAKING Changes: 2 out of 2
  • Modifications: 2
  • Breaking Modifications: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/22785421239/artifacts/5806866955

API Coverage

Before After Δ
Covered (%) 666 (65.23 %) 666 (65.23 %) 0 (0 %)
Uncovered (%) 355 (34.77 %) 355 (34.77 %) 0 (0 %)
Unknown 149 149 0

…ions schema

- Change num_partitions and partition fields from int64 to int32 format
- Remove x-protobuf-excluded flag from order field in aggregation schema

Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
Signed-off-by: yiyuabc <yypan14@gmail.com>
@yiyuabc yiyuabc force-pushed the fix-aggregations-schema-format branch from 767d0f4 to f5a2b3d Compare March 6, 2026 22:57
@karenyrx karenyrx merged commit 8d5d6d5 into opensearch-project:main Mar 6, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants