Skip to content

Updated MAINTAINERS.md format.#589

Merged
lezzago merged 1 commit intoopensearch-project:mainfrom
dblock:updated-maintainers
Jan 24, 2023
Merged

Updated MAINTAINERS.md format.#589
lezzago merged 1 commit intoopensearch-project:mainfrom
dblock:updated-maintainers

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Jan 5, 2023

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format.

@dblock dblock requested a review from a team January 5, 2023 17:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.36%. Comparing base (5b9ff98) to head (923955e).
⚠️ Report is 136 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #589   +/-   ##
=========================================
  Coverage     61.36%   61.36%           
  Complexity      112      112           
=========================================
  Files            73       73           
  Lines          2472     2472           
  Branches        265      265           
=========================================
  Hits           1517     1517           
  Misses          778      778           
  Partials        177      177
Flag Coverage Δ
opensearch-notifications 61.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

@qreshi
Copy link
Copy Markdown
Contributor

qreshi commented Jan 5, 2023

Looks like some CI has failed. This change has no code changes, can someone please take a look at that?

Just took a look. The failures for the backend and frontend CI are known flaky test issues. There are tracking issues to address those.

The failure in the Security test CI happened after upgrading to 3.0 (it's related to a dependent library and not from Notifications itself) and the fix for it is currently in review here #583

I think you're good to proceed in merging this PR.

This was referenced Jan 5, 2023
Closed
Closed
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Jan 19, 2023

I don't have permissions to this repo. Who's looking at this?

@lezzago lezzago merged commit b5379b6 into opensearch-project:main Jan 24, 2023
@dblock dblock deleted the updated-maintainers branch January 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lezzago lezzago lezzago approved these changes

@qreshi qreshi qreshi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dblock @codecov-commenter @qreshi @lezzago