Flush remaining data to S3 during shutdown#6424
Merged
dlvenable merged 2 commits intoopensearch-project:mainfrom Feb 5, 2026
Merged
Flush remaining data to S3 during shutdown#6424dlvenable merged 2 commits intoopensearch-project:mainfrom
dlvenable merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Subrahmanyam-Gollapalli <subrahmanyam.gollapalli@freshworks.com>
dlvenable
requested changes
Jan 29, 2026
Member
dlvenable
left a comment
There was a problem hiding this comment.
Thank you @Subrahmanyam-Gollapalli for this contribution! I think this approach makes sense to avoid data loss. I have one comment on adding tests here.
| * Force flush all remaining S3 groups to S3. This is called during shutdown | ||
| * to ensure all buffered data is uploaded before the sink shuts down. | ||
| */ | ||
| void flushAllRemainingGroups() { |
Member
There was a problem hiding this comment.
Please add unit tests on this to ensure that we do correctly flush all the groups.
Member
There was a problem hiding this comment.
Thanks for making this change! The change looks good but we should have some unit tests
Signed-off-by: Subrahmanyam-Gollapalli <subrahmanyam.gollapalli@freshworks.com>
dlvenable
approved these changes
Feb 5, 2026
Member
dlvenable
left a comment
There was a problem hiding this comment.
Nice, thank you @Subrahmanyam-Gollapalli !
graytaylor0
approved these changes
Feb 5, 2026
Member
graytaylor0
left a comment
There was a problem hiding this comment.
Thanks for this change and for adding the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add shutdown method to ensure all remaining buffered data is flushed to S3 before the sink shuts down
Issues Resolved
Prevents data loss when the sink is stopped.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.