Add acknowledgment checkpointing with fixes to previous issues#6002
Merged
graytaylor0 merged 4 commits intoopensearch-project:mainfrom Aug 19, 2025
Merged
Add acknowledgment checkpointing with fixes to previous issues#6002graytaylor0 merged 4 commits intoopensearch-project:mainfrom
graytaylor0 merged 4 commits intoopensearch-project:mainfrom
Conversation
…temporarily (opensearch-project#5967)" (opensearch-project#5976)" (opensearch-project#5980)" This reverts commit 7b8478b. Signed-off-by: Taylor Gray <tylgry@amazon.com>
…ing acknowledgments Signed-off-by: Taylor Gray <tylgry@amazon.com>
JonahCalvo
approved these changes
Aug 18, 2025
Contributor
JonahCalvo
left a comment
There was a problem hiding this comment.
Great, thanks for helping me out with this new feature!
dlvenable
reviewed
Aug 18, 2025
| return sequenceNumber; | ||
| } | ||
|
|
||
| public boolean isPositiveAcknowledgement() { |
Member
There was a problem hiding this comment.
Please add unit tests for these methods with logic.
| .shardId(shardId) | ||
| .streamArn(streamArn) | ||
| .shardIteratorType(ShardIteratorType.AT_SEQUENCE_NUMBER) | ||
| .shardIteratorType(ShardIteratorType.AFTER_SEQUENCE_NUMBER) |
Member
There was a problem hiding this comment.
This should be verified in the unit test.
| // Verify that saveProgressStateForPartition is called | ||
| verify(sourceCoordinator).saveProgressStateForPartition(eq(streamPartition), any(Duration.class)); | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
This class looks like it could use more test cases.
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
san81
reviewed
Aug 19, 2025
| public boolean equals(Object o) { | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| StreamPartition that = (StreamPartition) o; | ||
| return Objects.equals(shardId, that.shardId); |
Collaborator
There was a problem hiding this comment.
shardIds across different Stream-ARNs will be different? Just making sure shardIds won't get repeated
Member
Author
There was a problem hiding this comment.
They should be unique, but we will evaluate if we ever enable support for more than one table in the future.
dlvenable
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change reverts a previous commit that removed the changes to checkpoint acknowledgments for streams in the dynamodb source. It then adds some changes that locally have fixed the issues that were seen during acknowledgment checkpointing with data loss and acknowledgment timeouts
Issues Resolved
Resolves #4764
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.