Add detect format processor#5774
Merged
kkondaka merged 2 commits intoopensearch-project:mainfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
sb2k16
previously approved these changes
Jun 13, 2025
san81
reviewed
Jun 13, 2025
| sourceData = sourceData.trim(); | ||
|
|
||
| // JSON: Starts with { and ends with } | ||
| if (sourceData.startsWith("{") && sourceData.endsWith("}")) { |
Collaborator
There was a problem hiding this comment.
For json, it could also start with [ and end with ]
san81
reviewed
Jun 13, 2025
| if (commas == expectedCommas) | ||
| numMatches++; | ||
| } | ||
| if (numMatches >= lines.length/2) { |
Collaborator
There was a problem hiding this comment.
If we trying to look for half of the rows having same number of commas with in the number of lines we are checking, then probably this condition should look like numMatches >= Math.min(lines.length, 10)/2
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
san81
approved these changes
Jun 13, 2025
Collaborator
san81
left a comment
There was a problem hiding this comment.
nice addition to the processors
sb2k16
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add detect format processor which detects format of the data in the specified field.
Issues Resolved
Resolves #5731
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.