Introduces the experimental plugin feature#5318
Merged
dlvenable merged 2 commits intoopensearch-project:mainfrom Jan 15, 2025
Merged
Introduces the experimental plugin feature#5318dlvenable merged 2 commits intoopensearch-project:mainfrom
dlvenable merged 2 commits intoopensearch-project:mainfrom
Conversation
…s to mark plugins as experimental. This PR adds a new annotation @experimental which can be applied to plugin types. When loading plugins, the plugin framework will now check whether the plugin is experimental or not. If the plugin is experimental, Data Prepper will fail if experimental plugins are not enabled. This PR also adds a new configuration in data-prepper-config.yaml to enable all experimental plugins if they are desired. Additionally, I refactored the code that logs deprecated plugin names into a consumer to help the overall code structure and fit the code design I took for checking for experimental plugins. Resolves opensearch-project#2695 Signed-off-by: David Venable <dlv@amazon.com>
0f246ee to
0bb02eb
Compare
san81
reviewed
Jan 14, 2025
Collaborator
san81
left a comment
There was a problem hiding this comment.
Thank you for adding this. This is a really clean separation! Let just a minor comment.
| @@ -0,0 +1,26 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
Newly added files could use the new copyright message
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*
*/
Member
Author
There was a problem hiding this comment.
@san81 , Thank you for catching this. I have updated all the new files with this header.
Signed-off-by: David Venable <dlv@amazon.com>
oeyh
approved these changes
Jan 15, 2025
san81
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces the experimental plugin feature, allowing plugin developers to mark plugins as experimental.
This PR adds a new annotation
@Experimentalwhich can be applied to plugin types. When loading plugins, the plugin framework will now check whether the plugin is experimental or not. If the plugin is experimental, Data Prepper will fail if experimental plugins are not enabled. This PR also adds a new configuration indata-prepper-config.yamlto enable all experimental plugins if they are desired.New configuration:
Additionally, I refactored the code that logs deprecated plugin names into a consumer to help the overall code structure and fit the code design I took for checking for experimental plugins.
Issues Resolved
Resolves #2695
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.