[Docker] Do not run container as root#5314
Merged
dlvenable merged 5 commits intoopensearch-project:mainfrom Jan 14, 2025
Merged
[Docker] Do not run container as root#5314dlvenable merged 5 commits intoopensearch-project:mainfrom
dlvenable merged 5 commits intoopensearch-project:mainfrom
Conversation
Fixes opensearch-project#5311 Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
janhoy
commented
Jan 8, 2025
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Contributor
Author
|
So I think this is ready. Tested it in a k8s cluster using helm chart and this container security context: securityContext:
capabilities:
drop:
- ALL
runAsNonRoot: true
runAsUser: 1000
runAsGroup: 1000Prepper container ran as it should, under the new user. I'll follow up with a PR to the helm chart repo to add this security context (commented-out). Only once a new docker image version is released can we make such config default. EDIT: Well, such a commented section already exists, so guess there is no need for change until we can uncomment. |
Contributor
Author
|
Thanks for approving. Are the test failures related to the changes by any chance? |
Member
|
@janhoy , No, these are flaky tests. We can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Dockerfile, run under the
nobodyuser instead of root. Also chown some directories.Issues Resolved
Resolves #5311
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.