Allow ~ in keys for escaped json pointer characters#5111
Merged
graytaylor0 merged 1 commit intoopensearch-project:mainfrom Oct 29, 2024
Merged
Allow ~ in keys for escaped json pointer characters#5111graytaylor0 merged 1 commit intoopensearch-project:mainfrom
graytaylor0 merged 1 commit intoopensearch-project:mainfrom
Conversation
dlvenable
requested changes
Oct 29, 2024
| || c == '.' | ||
| || c == '-' | ||
| || c == '_' | ||
| || c == '~' |
Member
There was a problem hiding this comment.
Please include this in the unit tests.
Signed-off-by: Taylor Gray <tylgry@amazon.com>
dlvenable
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Json pointer uses ~ character as the escape sequence in some places. For example, a literal / in the key name will be escaped with ~1, but Data Prepper JacksonEventKey is blocking this by not allowing ~ character
Issues Resolved
Resolves #5101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.