Skip to content

Jackson 2.13.4#1871

Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom
dlvenable:jackson-2.13.4
Oct 4, 2022
Merged

Jackson 2.13.4#1871
dlvenable merged 1 commit intoopensearch-project:mainfrom
dlvenable:jackson-2.13.4

Conversation

@dlvenable
Copy link
Copy Markdown
Member

@dlvenable dlvenable commented Oct 3, 2022

Description

Update to Jackson 2.13.4. Removed a specific version to keep all versions using the root BOM.

Issues Resolved

Resolves #1839
Resolves #1867

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable requested a review from a team as a code owner October 3, 2022 21:57
@dlvenable dlvenable changed the title Jackson 2.13.4. Jackson 2.13.4 Oct 3, 2022
implementation 'software.amazon.awssdk:sqs'
implementation 'com.fasterxml.jackson.core:jackson-core'
implementation 'com.fasterxml.jackson.core:jackson-databind:2.13.4'
implementation 'com.fasterxml.jackson.core:jackson-databind'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will gradle decide which version to use?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the BOM (Bill of Materials) file defined in the root project. This way, all Jackson projects use the same version and we manage that version in one place.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 4, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.00%. Comparing base (5a73bf3) to head (e777f22).
⚠️ Report is 1994 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1871      +/-   ##
============================================
- Coverage     94.03%   94.00%   -0.03%     
  Complexity     1525     1525              
============================================
  Files           192      192              
  Lines          4474     4490      +16     
  Branches        364      365       +1     
============================================
+ Hits           4207     4221      +14     
- Misses          184      185       +1     
- Partials         83       84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlvenable dlvenable merged commit e1ee89d into opensearch-project:main Oct 4, 2022
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1871-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1ee89d12db977f9110a6a42452248524b893eff
# Push it to GitHub
git push --set-upstream origin backport/backport-1871-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1871-to-1.x.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 1.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5 1.5
# Navigate to the new working tree
cd .worktrees/backport-1.5
# Create a new branch
git switch --create backport/backport-1871-to-1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1ee89d12db977f9110a6a42452248524b893eff
# Push it to GitHub
git push --set-upstream origin backport/backport-1871-to-1.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5

Then, create a pull request where the base branch is 1.5 and the compare/head branch is backport/backport-1871-to-1.5.

@dlvenable dlvenable deleted the jackson-2.13.4 branch October 5, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVE-2022-42004 (Medium) detected in jackson-databind-2.13.3.jar Bump jackson and snakeyaml dependencies

4 participants