-
Notifications
You must be signed in to change notification settings - Fork 313
Migrate existing plugins to use POJO configuration classes. #5246
Copy link
Copy link
Closed
Labels
maintenanceIssues to help maintain the project, such as improving builds, testing, etc.Issues to help maintain the project, such as improving builds, testing, etc.
Milestone
Description
All plugins should configure the pluginConfigurationType attribute in @DataPrepperPlugin with a custom POJO configuration class. Some older plugins still use PluginSettings. These should be updated to use a POJO configuration class.
For example, the s3 source does this correctly.
Line 36 in f6a06a0
| @DataPrepperPlugin(name = "s3", pluginType = Source.class, pluginConfigurationType = S3SourceConfig.class) |
The opensearch sink is doing this using PluginSettings which we do not want.
Line 89 in 1ddebf6
| @DataPrepperPlugin(name = "opensearch", pluginType = Sink.class) |
- Update the OpenSearch sink to use a POJO configuration class.
- Look for any other plugins that use the
PluginSettings.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
maintenanceIssues to help maintain the project, such as improving builds, testing, etc.Issues to help maintain the project, such as improving builds, testing, etc.
Type
Projects
Status
Done