Skip to content

[Backport 2.11] Feature findings enhancemnt#619

Merged
jowg-amazon merged 1 commit into2.11from
backport-596-to-2.11
Mar 15, 2024
Merged

[Backport 2.11] Feature findings enhancemnt#619
jowg-amazon merged 1 commit into2.11from
backport-596-to-2.11

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport 892c34f from #596.

* added support for  param in Finding API

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* added detectionType as param for Findings API enhancements

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* adding addiional params findingIds, startTime and endTime

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix klint errors

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit 892c34f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.90%. Comparing base (b7872ea) to head (46ba608).

Files Patch % Lines
...arch/commons/alerting/action/GetFindingsRequest.kt 77.77% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #619      +/-   ##
============================================
- Coverage     73.91%   73.90%   -0.01%     
- Complexity      853      857       +4     
============================================
  Files           130      130              
  Lines          5685     5710      +25     
  Branches        698      698              
============================================
+ Hits           4202     4220      +18     
- Misses         1173     1180       +7     
  Partials        310      310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit 9805106 into 2.11 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants