Skip to content

[Backport 2.12] Feature findings enhancemnt#607

Merged
riysaxen-amzn merged 1 commit into2.12from
backport-596-to-2.12
Mar 11, 2024
Merged

[Backport 2.12] Feature findings enhancemnt#607
riysaxen-amzn merged 1 commit into2.12from
backport-596-to-2.12

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport 892c34f from #596.

* added support for  param in Finding API

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* added detectionType as param for Findings API enhancements

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* adding addiional params findingIds, startTime and endTime

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

* fix klint errors

Signed-off-by: Riya Saxena <riysaxen@amazon.com>

---------

Signed-off-by: Riya Saxena <riysaxen@amazon.com>
(cherry picked from commit 892c34f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 72.86%. Comparing base (eb98199) to head (55687ae).

Files Patch % Lines
...arch/commons/alerting/action/GetFindingsRequest.kt 77.77% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.12     #607      +/-   ##
============================================
+ Coverage     72.84%   72.86%   +0.01%     
- Complexity      863      867       +4     
============================================
  Files           133      133              
  Lines          5823     5848      +25     
  Branches        716      716              
============================================
+ Hits           4242     4261      +19     
- Misses         1266     1273       +7     
+ Partials        315      314       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riysaxen-amzn riysaxen-amzn requested review from eirsep and engechas March 9, 2024 04:07
@riysaxen-amzn riysaxen-amzn merged commit 4ba029a into 2.12 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants