Conversation
…or publishing legacy notifications, and method for executing transport action Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
akbhatta
suggested changes
Aug 3, 2021
Contributor
akbhatta
left a comment
There was a problem hiding this comment.
I will continue the review after I get info current quires.
src/main/java/org/opensearch/commons/destination/message/LegacyBaseMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyBaseMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyBaseMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyBaseMessage.java
Show resolved
Hide resolved
| if (url == null) { | ||
| throw new IllegalArgumentException("url is invalid or empty"); | ||
| } | ||
| this.url = url; |
Contributor
There was a problem hiding this comment.
Please validate that schema is https. http schema is not supported.
Contributor
Author
There was a problem hiding this comment.
http must be supported as alerting and ism have already supported it in production
src/main/java/org/opensearch/commons/destination/message/LegacyBaseMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyChimeMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyCustomWebhookMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyCustomWebhookMessage.java
Show resolved
Hide resolved
src/main/java/org/opensearch/commons/destination/message/LegacyChimeMessage.java
Show resolved
Hide resolved
Contributor
Author
|
Don't have access to push to this branch once it's been created in the repo it seems... going to close this and recreate on fork. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or publishing legacy notifications, and method for executing transport action
Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com
Description
Adds required legacy messages, request/response classes, and methods for ISM to publish a notification through the notification plugin with the old embedded types without having to create a channel first.
opensearch-project/notifications#253
Issues Resolved
#44
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.