Skip to content

Address build failures #367

Merged
lezzago merged 1 commit intoopensearch-project:mainfrom
MaxKsyunz:build-fixes-xcore
Feb 22, 2023
Merged

Address build failures #367
lezzago merged 1 commit intoopensearch-project:mainfrom
MaxKsyunz:build-fixes-xcore

Conversation

@MaxKsyunz
Copy link
Copy Markdown
Contributor

@MaxKsyunz MaxKsyunz commented Feb 22, 2023 •
edited
Loading

Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Address build failures
f7908d0 
Several classes in core were moved to another package
causing builds to fail.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@MaxKsyunz MaxKsyunz requested a review from a team February 22, 2023 04:30
@MaxKsyunz MaxKsyunz mentioned this pull request Feb 22, 2023
Merged
1 task
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #367 (f7908d0) into main (3869c74) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #367      +/-   ##
============================================
- Coverage     73.30%   73.27%   -0.04%     
- Complexity      698      699       +1     
============================================
  Files           110      110              
  Lines          4612     4614       +2     
  Branches        606      608       +2     
============================================
  Hits           3381     3381              
  Misses          980      980              
- Partials        251      253       +2
Impacted Files Coverage Δ
...ain/java/org/opensearch/commons/authuser/User.java 87.82% <ø> (ø)
...ommons/alerting/action/AcknowledgeAlertResponse.kt 41.66% <ø> (ø)
...h/commons/alerting/action/DeleteMonitorResponse.kt 20.00% <ø> (ø)
...earch/commons/alerting/action/GetAlertsResponse.kt 100.00% <ø> (ø)
...rch/commons/alerting/action/GetFindingsResponse.kt 70.83% <ø> (ø)
...ch/commons/alerting/action/IndexMonitorResponse.kt 66.66% <ø> (ø)
...selectorext/BucketSelectorExtAggregationBuilder.kt 46.03% <ø> (ø)
...ation/bucketselectorext/BucketSelectorExtFilter.kt 40.00% <ø> (ø)
...egation/bucketselectorext/BucketSelectorIndices.kt 0.00% <ø> (ø)
...g/opensearch/commons/alerting/alerts/AlertError.kt 31.81% <ø> (ø)
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit af292c3 into opensearch-project:main Feb 22, 2023
@peternied
Copy link
Copy Markdown
Member

peternied commented Feb 22, 2023

Thank you @MaxKsyunz !

@lezzago lezzago mentioned this pull request Feb 22, 2023
Closed
5 tasks
@MaxKsyunz MaxKsyunz deleted the build-fixes-xcore branch February 22, 2023 19:01
@nknize nknize mentioned this pull request Mar 27, 2023
Closed
@MaxKsyunz
Copy link
Copy Markdown
Contributor Author

MaxKsyunz commented Mar 28, 2023

@peternied @lezzago could you label this PR with backport to 2.x?

Now that XContent refactor is in OpenSearch 2.x, common-utils 2.x build fails. I confirmed locally that backporting these changes is sufficient to make it build again.

@rupal-bq
Copy link
Copy Markdown

rupal-bq commented Mar 28, 2023

Now that XContent refactor is in OpenSearch 2.x, common-utils 2.x build fails. I confirmed locally that backporting these changes is sufficient to make it build again.

@MaxKsyunz Looks like this is addressed in #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezzago lezzago lezzago approved these changes

+1 more reviewer

@peternied peternied peternied approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaxKsyunz @codecov-commenter @peternied @rupal-bq @lezzago