[Feature/extensions] Get namedXContentRegistry from ExtensionsRunner#725
Merged
dbwiddis merged 6 commits intoopensearch-project:feature/extensionsfrom Nov 18, 2022
Merged
Conversation
owaiskazi19
reviewed
Nov 14, 2022
owaiskazi19
reviewed
Nov 14, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
ded8003 to
b5b8677
Compare
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Member
|
@dbwiddis looks like you have to rebase with feature/extensions to get the successful build? |
owaiskazi19
approved these changes
Nov 15, 2022
ryanbogan
approved these changes
Nov 18, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
approved these changes
Nov 18, 2022
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/extensions #725 +/- ##
========================================================
- Coverage 53.81% 53.35% -0.46%
+ Complexity 2679 2658 -21
========================================================
Files 288 290 +2
Lines 16004 16058 +54
Branches 1703 1686 -17
========================================================
- Hits 8612 8568 -44
- Misses 6767 6872 +105
+ Partials 625 618 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Requires SDK #244 to be merged first.
Description
Simplifies
AnomalyDetectorExtension:BaseExtensionto simplify extension settings and remove unneeded overridesExtensionsRunnerduring init, to be merged with core NamedXContentnamedXContentRegistryfrom the Extensions Runner and passes it to the REST handlerIssues Resolved
SDK #208
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.