[Feature/extensions] Create Detector Workflow by owaiskazi19 · Pull Request #692 · opensearch-project/anomaly-detection

owaiskazi19 · 2022-10-13T20:18:11Z

Description

~~This is an initial draft PR for create detector workflow.~~

When creating an index and having the method markMappingUpToDate which requires an actionListener. I have passed it as null for now but we need to figure out a way for this mapping. Or do we even need a listener because we can get the Response directly while creating the AD_Index from SDKClient.

Need to wait for createComponent integration to finish so that we will get an object for AnomalyDetectionIndices to call markMappingUpToDate

Not able to start AD Extension because while creating the handler I'm passing null for settings and clusterService
handler = List.of(new RestCreateDetectorAction(null, null)); as these objects will be available through createComponent

This PR adds:

Create Detector workflow for AD Extension
Migrate client transports to Apache HttpClient / Core 5.x

Issues Resolved

opensearch-project/opensearch-sdk-java#58

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java

src/main/java/org/opensearch/ad/rest/RestCreateDetectorAction.java

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

codecov-commenter · 2022-11-04T23:00:57Z

Codecov Report

Merging #692 (258faea) into feature/extensions (11d094a) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

❗ Current head 258faea differs from pull request most recent head 2ee1a1e. Consider uploading reports for the commit 2ee1a1e to get more accurate results

@@                   Coverage Diff                    @@
##             feature/extensions     #692      +/-   ##
========================================================
- Coverage                 53.81%   53.37%   -0.44%     
  Complexity                 2679     2679              
========================================================
  Files                       288      290       +2     
  Lines                     16004    16134     +130     
  Branches                   1703     1706       +3     
========================================================
  Hits                       8612     8612              
- Misses                     6767     6897     +130     
  Partials                    625      625

Flag	Coverage Δ
plugin	`53.37% <0.00%> (-0.44%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java	`0.00% <0.00%> (ø)`
...main/java/org/opensearch/ad/auth/UserIdentity.java	`54.78% <ø> (ø)`
.../java/org/opensearch/ad/model/AnomalyDetector.java	`90.00% <ø> (ø)`
...g/opensearch/ad/rest/RestCreateDetectorAction.java	`0.00% <0.00%> (ø)`
...ensearch/ad/transport/ADCancelTaskNodeRequest.java	`34.78% <ø> (ø)`
...rg/opensearch/ad/transport/ADStatsNodeRequest.java	`100.00% <ø> (ø)`
...nsearch/ad/transport/ADTaskProfileNodeRequest.java	`0.00% <ø> (ø)`
...a/org/opensearch/ad/transport/CronNodeRequest.java	`100.00% <ø> (ø)`
...pensearch/ad/transport/DeleteModelNodeRequest.java	`90.90% <ø> (ø)`
...rg/opensearch/ad/transport/ProfileNodeRequest.java	`91.66% <ø> (ø)`
... and 3 more

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

dbwiddis

LGTM! Great job! A few comments (can be resolved to merge).

src/main/java/org/opensearch/ad/model/AnomalyDetector.java

src/main/java/org/opensearch/ad/rest/RestCreateDetectorAction.java

owaiskazi19 added 4 commits October 12, 2022 15:38

Removed opensearchplugin and ran extension independently

b9a4ded

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Initial create detector

27a8b05

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Initial draft for create detector workflow

c6b86af

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Removed empty constructor

15cbf9f

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

owaiskazi19 requested a review from dbwiddis October 13, 2022 20:18

Removed comments

d016034

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

dbwiddis reviewed Oct 14, 2022

View reviewed changes

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java Outdated Show resolved Hide resolved

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java Outdated Show resolved Hide resolved

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java Show resolved Hide resolved

owaiskazi19 added 7 commits October 25, 2022 20:05

Integrated create index with mapping

20a4c5a

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Changed access specifier

2c8bdbb

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Parser error

058dcd3

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Added namedXContent for create detector

ca2bd53

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Implemented create detector

c087d17

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Formatted the code

fdadeef

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Updated build.gradle

39c1c3a

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

dbwiddis mentioned this pull request Oct 29, 2022

[FEATURE] Document how to use Java 8 Time (JSR 310) objects opensearch-project/opensearch-java#250

Closed

dbwiddis reviewed Oct 30, 2022

View reviewed changes

dbwiddis mentioned this pull request Oct 31, 2022

[FEATURE] Give Extensions access to core NamedXContent opensearch-project/opensearch-sdk-java#208

Closed

Migrate client transports to Apache HttpClient / Core 5.x

f179359

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

owaiskazi19 marked this pull request as ready for review November 4, 2022 22:49

owaiskazi19 requested review from a team and dbwiddis November 4, 2022 22:49

Removed jackson dependency

258faea

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

Changed dynamic mapping to string

2ee1a1e

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

owaiskazi19 mentioned this pull request Nov 7, 2022

[Feature/extensions] Implement createDetector request in AD Extension opensearch-project/opensearch-sdk-java#58

Closed

6 tasks

dbwiddis approved these changes Nov 7, 2022

View reviewed changes

src/main/java/org/opensearch/ad/model/AnomalyDetector.java Show resolved Hide resolved

src/main/java/org/opensearch/ad/rest/RestCreateDetectorAction.java Show resolved Hide resolved

owaiskazi19 requested a review from joshpalis November 7, 2022 21:22

owaiskazi19 requested a review from ryanbogan November 7, 2022 21:22

ryanbogan approved these changes Nov 7, 2022

View reviewed changes

owaiskazi19 merged commit 5fdb72a into opensearch-project:feature/extensions Nov 7, 2022

dbwiddis changed the title ~~Create Detector Workflow~~ [Feature/extensions] Create Detector Workflow Nov 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/extensions] Create Detector Workflow#692

[Feature/extensions] Create Detector Workflow#692
owaiskazi19 merged 15 commits intoopensearch-project:feature/extensionsfrom
owaiskazi19:create-index

owaiskazi19 commented Oct 13, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Nov 4, 2022 •

edited

Loading

Uh oh!

dbwiddis left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

owaiskazi19 commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbwiddis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

owaiskazi19 commented Oct 13, 2022 •

edited

Loading

codecov-commenter commented Nov 4, 2022 •

edited

Loading