Skip to content

[Backport 1.2] Adding support for integration tests with remote cluster. (#298)#311

Merged
saratvemulapalli merged 1 commit intoopensearch-project:1.2from
saratvemulapalli:1.2
Nov 11, 2021
Merged

[Backport 1.2] Adding support for integration tests with remote cluster. (#298)#311
saratvemulapalli merged 1 commit intoopensearch-project:1.2from
saratvemulapalli:1.2

Conversation

@saratvemulapalli
Copy link
Copy Markdown
Member

@saratvemulapalli saratvemulapalli commented Nov 11, 2021

Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com

Description

Backport to 1.2: Adding support for integration tests with remote cluster.

Issues Resolved

opensearch-project/OpenSearch#1240
opensearch-project/opensearch-plugins#101
Closes #315

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Copy link
Copy Markdown
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you backport to 1.x as well?

@saratvemulapalli
Copy link
Copy Markdown
Member Author

Thanks! Can you backport to 1.x as well?

Good point. Sure.

@peternied
Copy link
Copy Markdown
Member

Just had a quick conversation with @saratvemulapalli offline, when this change goes in we also need an update in the integration test script to invoke the new gradle task otherwise it will fail.

@saratvemulapalli
Copy link
Copy Markdown
Member Author

I have no idea why the tests are failing. Not sure if I did a clean merge.
Will merge changes from origin to my fork and try again.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 11, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.20%. Comparing base (17ada48) to head (60bd0ec).
⚠️ Report is 22 commits behind head on 1.2.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                1.2     #311      +/-   ##
============================================
- Coverage     76.27%   76.20%   -0.07%     
+ Complexity     3966     3963       -3     
============================================
  Files           295      295              
  Lines         17165    17182      +17     
  Branches       1812     1812              
============================================
+ Hits          13092    13094       +2     
- Misses         3252     3270      +18     
+ Partials        821      818       -3     
Flag Coverage Δ
plugin 76.20% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saratvemulapalli saratvemulapalli merged commit 3fad91d into opensearch-project:1.2 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants