Bump Node.js from 10.23.1 to 10.24.1#544
Conversation
|
✅ DCO Check Passed 758df84 |
|
✅ DCO Check Passed 1c39e16 |
|
Updated the commit message for the |
|
✅ DCO Check Passed 5488c25 |
ananzh
left a comment
There was a problem hiding this comment.
Nice. I tested these two commits yesterday and it fixed my jenkins pipeline
|
✅ DCO Check Passed 0523d65 |
|
✅ DCO Check Passed 0c05f72 |
a43acbf to
09b15d8
Compare
|
❌ DCO Check Failed a43acbf |
|
✅ DCO Check Passed 09b15d8 |
Bumps [node](https://github.com/nodejs/node) from 10.23.1 to 10.24.1 - [Release notes](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.24.1) Signed-off-by: Tommy Markley <markleyt@amazon.com>
|
✅ DCO Check Passed a772f8c |
|
We may need to get an admin to "remove the outdated check in the protected branch settings of the repository settings" as referenced in this GitHub community post: https://github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157 Note on how admins can do this in the future: Settings -> Branches -> Branch protection rules (main branch) click Edit -> in Require status checks to pass before merging -> either add a check or remove a check -> Save. |
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 |
There was a problem hiding this comment.
This was the magic sauce to make it build? Nice.
There was a problem hiding this comment.
It was building without this, but I wanted to simplify. Getting all of the checks to pass still required admin intervention, and I documented the steps in this comment.
Description
Bumps node from 10.23.1 to 10.24.1
Testing
Some basic manual smoke tests were run locally as well as running all tests in Jenkins:
Issues Resolved
Last Node.js bump before tackling #406
Check List