Skip to content

[Backport 2.x] [Refactor] Refactors remaining ImmutableOpenMap usage to j.u.Map (#7309)#8316

Merged
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-7309-to-2.x
Jun 30, 2023
Merged

[Backport 2.x] [Refactor] Refactors remaining ImmutableOpenMap usage to j.u.Map (#7309)#8316
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-7309-to-2.x

Conversation

@nknize
Copy link
Copy Markdown
Contributor

@nknize nknize commented Jun 28, 2023

Backport d984f50 from #7309.

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments labels Jun 28, 2023
@nknize nknize added the v2.9.0 'Issues and PRs related to version v2.9.0' label Jun 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2023

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Copy Markdown
Contributor Author

nknize commented Jun 28, 2023

Okay, this is beyond ridiculous. These same BWC and Segrep w/ remote store tests keep failing. We need to either mute or fix them as the time loss has far surpassed unreasonable.

@nknize
Copy link
Copy Markdown
Contributor Author

nknize commented Jun 28, 2023

I was able to periodically repro the Yaml test failures. Looks like there's an occasional java.net.ConnectException: Connection refused. Many of these instances occur from adminClient().performRequest(request); called from ensureNoInitializingShards(); I'm not sure this is specific to this call, though. Possibly we're running out of connections based on the cluster config?

Will keep digging.

@ketanv3 ketanv3 mentioned this pull request Jun 29, 2023
Merged
6 tasks
@nknize
[Refactor] Refactors remaining ImmutableOpenMap usage to j.u.Map (ope…
0ad7ad3 
…nsearch-project#7309)

Refactors all remaining usage of HPPC backed ImmutableOpenMap to
j.u.Map. This is the last usage of the class so ImmutableOpenMap is
completely removed in favor of java maps.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit d984f50)
@nknize nknize force-pushed the backport/backport-7309-to-2.x branch from 7aeebbf to 0ad7ad3 Compare June 30, 2023 15:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2023

Codecov Report

Merging #8316 (0ad7ad3) into 2.x (04ec607) will decrease coverage by 0.02%.
The diff coverage is 91.48%.

@@             Coverage Diff              @@
##                2.x    #8316      +/-   ##
============================================
- Coverage     70.69%   70.68%   -0.02%     
- Complexity    56900    56901       +1     
============================================
  Files          4714     4713       -1     
  Lines        269657   269540     -117     
  Branches      39863    39856       -7     
============================================
- Hits         190640   190511     -129     
- Misses        62611    62684      +73     
+ Partials      16406    16345      -61
Impacted Files Coverage Δ
...cluster/reroute/TransportClusterRerouteAction.java 44.73% <0.00%> (+0.58%) ⬆️
...ices/shards/TransportIndicesShardStoresAction.java 4.90% <0.00%> (ø)
...a/org/opensearch/common/io/stream/StreamInput.java 88.60% <ø> (-1.32%) ⬇️
.../org/opensearch/common/io/stream/StreamOutput.java 94.81% <ø> (-0.38%) ⬇️
.../src/main/java/org/opensearch/gateway/Gateway.java 8.33% <0.00%> (ø)
.../opensearch/rest/action/cat/RestIndicesAction.java 45.77% <0.00%> (-0.12%) ⬇️
...min/indices/shards/IndicesShardStoresResponse.java 53.19% <71.42%> (+1.41%) ⬆️
...dmin/indices/settings/get/GetSettingsResponse.java 74.39% <91.66%> (-0.61%) ⬇️
.../java/org/opensearch/index/mapper/FieldMapper.java 80.75% <94.11%> (+0.01%) ⬆️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 87.62% <97.43%> (-1.60%) ⬇️
... and 18 more

... and 429 files with indirect coverage changes

@nknize nknize merged commit 96d4fa7 into opensearch-project:2.x Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Merged
This was referenced Jun 30, 2023
Merged
Merged
This was referenced Jul 11, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

Assignees

No one assigned

Labels

backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.9.0 'Issues and PRs related to version v2.9.0'

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nknize @reta