Closed
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
Author
|
@nknize please |
nknize
suggested changes
Jan 25, 2023
Contributor
nknize
left a comment
There was a problem hiding this comment.
Let's wait on this (see comment reply). Doing this now will block refactoring other :server base classes needed to decouple the gaggs and field mapper framework.
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
Add
XContentMediaTypeto breakXContentandMediaTypecoupling, plus making the change non-breaking to allow backporting to2.xbranch.Issues Resolved
Follow up on #6009 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.