Add jvm option to allow security manager#5194
Merged
saratvemulapalli merged 1 commit intoopensearch-project:mainfrom Nov 10, 2022
adnapibar:jsm-option-allow
Merged
Add jvm option to allow security manager#5194saratvemulapalli merged 1 commit intoopensearch-project:mainfrom adnapibar:jsm-option-allow
saratvemulapalli merged 1 commit intoopensearch-project:mainfrom
adnapibar:jsm-option-allow
Conversation
This change explicitly sets JVM options to allow security manager. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5194 +/- ##
============================================
- Coverage 70.98% 70.94% -0.04%
+ Complexity 58169 58109 -60
============================================
Files 4708 4708
Lines 277559 277559
Branches 40189 40189
============================================
- Hits 197016 196925 -91
- Misses 64385 64430 +45
- Partials 16158 16204 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
saratvemulapalli
approved these changes
Nov 10, 2022
Member
|
@adnapibar do you want to back to 2.x? |
reta
reviewed
Nov 10, 2022
| } else { | ||
| test.systemProperty("java.locale.providers", "SPI,COMPAT"); | ||
| test.jvmArgs("--illegal-access=warn"); | ||
| test.jvmArgs("--illegal-access=warn", "-Djava.security.manager=allow"); |
Contributor
There was a problem hiding this comment.
@adnapibar thanks for the change, I believe we have to make it conditional based on JDK (the new allow setting was introduced in JDK-18 and onwards), otherwise JVM fails to start
Contributor
Author
There was a problem hiding this comment.
@reta thanks! for pointing that out, I'm updating it.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rabi Panda adnapibar@gmail.com
Description
This change explicitly sets JVM options to allow security manager.
Issues Resolved
Resolves #5193
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.