Skip to content

[Backport 2.x] [Remote Store] Change behaviour in replica recovery for remote translog enabled indices (#4318)#4873

Merged
andrross merged 2 commits intoopensearch-project:2.xfrom
ashking94:2.x
Oct 24, 2022
Merged

[Backport 2.x] [Remote Store] Change behaviour in replica recovery for remote translog enabled indices (#4318)#4873
andrross merged 2 commits intoopensearch-project:2.xfrom
ashking94:2.x

Conversation

@ashking94
Copy link
Copy Markdown
Member

Signed-off-by: Ashish Singh ssashish@amazon.com

Description

PR link to main: #4318

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 requested review from a team and reta as code owners October 21, 2022 19:10
@andrross
Copy link
Copy Markdown
Member

I believe this depends on #4857

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Copy Markdown
Member

@ashking94 I believe the test failures have been fixed and the dependent PR merged. Please rebase this the 2.x branch and it should pass the tests.

…og enabled indices (opensearch-project#4318)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4873 (e2989b2) into 2.x (0503897) will decrease coverage by 0.20%.
The diff coverage is 71.76%.

@@             Coverage Diff              @@
##                2.x    #4873      +/-   ##
============================================
- Coverage     70.76%   70.56%   -0.21%     
+ Complexity    57654    57551     -103     
============================================
  Files          4620     4620              
  Lines        276150   276196      +46     
  Branches      40408    40417       +9     
============================================
- Hits         195421   194896     -525     
- Misses        64406    65004     +598     
+ Partials      16323    16296      -27     
Impacted Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 70.08% <56.66%> (+0.07%) ⬆️
...ch/indices/recovery/PeerRecoveryTargetService.java 56.14% <66.66%> (+0.92%) ⬆️
...search/indices/recovery/RecoverySourceHandler.java 78.61% <83.78%> (-0.14%) ⬇️
...org/opensearch/index/shard/IndexShardTestCase.java 93.70% <100.00%> (-0.23%) ⬇️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...pensearch/client/cluster/RemoteConnectionInfo.java 0.00% <0.00%> (-70.00%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-63.16%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
... and 461 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashking94
Copy link
Copy Markdown
Member Author

@andrross - done.

@andrross
Copy link
Copy Markdown
Member

@ashking94 Can you fix the DCO on your latest commit?

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Copy Markdown
Member Author

@andrross - My bad. It's done now.

@andrross andrross merged commit 3df7015 into opensearch-project:2.x Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants