[Feature/extensions] Adding support for Extension Create Components [environment settings and add setting update consumers] by joshpalis · Pull Request #4517 · opensearch-project/OpenSearch

joshpalis · 2022-09-14T23:22:38Z

Description

Adds support for extensions to request environment setting values from opensearch, to add setting update consumers to cluster settings, and to receive update setting requests from Opensearch whenever a setting is updated.

Companion PR : opensearch-project/opensearch-sdk-java#138

Note : Currently in a draft state until opensearch-project/opensearch-sdk-java#79 is resolved

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…dated unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: Joshua Palis <jpalis@amazon.com>

…er settings from which they would like to retrieve values for Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: Joshua Palis <jpalis@amazon.com>

…Draft, as getSettings support still needs to be finalized Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-14T23:49:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3077/
CommitID: 097b239

codecov-commenter · 2022-09-14T23:51:45Z

Codecov Report

Merging #4517 (26362e4) into feature/extensions (edde6a4) will increase coverage by 0.00%.
The diff coverage is 79.35%.

@@                  Coverage Diff                   @@
##             feature/extensions    #4517    +/-   ##
======================================================
  Coverage                 70.57%   70.58%            
- Complexity                57370    57523   +153     
======================================================
  Files                      4642     4650     +8     
  Lines                    276302   276603   +301     
  Branches                  40389    40422    +33     
======================================================
+ Hits                     195012   195246   +234     
- Misses                    64936    65067   +131     
+ Partials                  16354    16290    -64

Impacted Files	Coverage Δ
...arch/extensions/UpdateSettingsResponseHandler.java	`0.00% <0.00%> (ø)`
.../opensearch/extensions/ExtensionsOrchestrator.java	`69.84% <61.29%> (+3.37%)`	⬆️
...g/opensearch/extensions/UpdateSettingsRequest.java	`63.33% <63.33%> (ø)`
...h/extensions/AddSettingsUpdateConsumerRequest.java	`75.75% <75.75%> (ø)`
...nsearch/extensions/EnvironmentSettingsRequest.java	`76.00% <76.00%> (ø)`
...nsions/settings/RegisterCustomSettingsRequest.java	`78.57% <78.57%> (ø)`
...rg/opensearch/env/EnvironmentSettingsResponse.java	`80.00% <80.00%> (ø)`
...g/opensearch/common/settings/WriteableSetting.java	`93.63% <93.63%> (ø)`
...opensearch/extensions/ExtensionStringResponse.java	`100.00% <100.00%> (ø)`
...rch/extensions/rest/RestActionsRequestHandler.java	`100.00% <100.00%> (ø)`
... and 506 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…tion Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-15T17:07:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3105/
CommitID: fab1cf8

Signed-off-by: Joshua Palis <jpalis@amazon.com>

…rder to make this setting object source clear Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-15T17:58:25Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3106/
CommitID: d9188d8

github-actions · 2022-09-15T18:24:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3107/
CommitID: e05ada9

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-16T19:52:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3144/
CommitID: 40fc4af

github-actions · 2022-09-16T19:57:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3145/
CommitID: fefb67c

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-16T23:13:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3159/
CommitID: 567a0ab

dbwiddis

Existing code LGTM with one inline comment.

The Request and Response objects with writeTo methods and constructors from InputStreams need test classes. Should be a few examples of the pattern (instantiate with the constructor with objects, then writeTo a byte stream and construct from that byte stream and verify equality.

server/src/main/java/org/opensearch/env/EnvironmentSettingsResponse.java

server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java

server/src/main/java/org/opensearch/extensions/UpdateSettingsResponseHandler.java

github-actions · 2022-09-19T23:39:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3225/
CommitID: 7a42ccb

github-actions · 2022-09-19T23:46:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3226/
CommitID: a1a199c

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-20T16:32:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3261/
CommitID: 96744dd

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-20T16:41:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3262/
CommitID: 0c4abfa

github-actions · 2022-09-20T17:04:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3267/
CommitID: 45bfb9d

CHANGELOG.md

github-actions · 2022-09-21T00:06:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3284/
CommitID: c39f34c

… the issue Re-run gradle check Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-21T20:06:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3298/
CommitID: 26362e4

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-22T20:12:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3324/
CommitID: f1d0d0d

Signed-off-by: Joshua Palis <jpalis@amazon.com>

server/src/test/java/org/opensearch/extensions/ExtensionsOrchestratorTests.java

github-actions · 2022-09-22T20:29:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3325/
CommitID: 2aec9ec

server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java

owaiskazi19

A small comment. Rest LGTM!

github-actions · 2022-09-22T20:42:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3326/
CommitID: 1237ebd

Signed-off-by: Joshua Palis <jpalis@amazon.com>

github-actions · 2022-09-23T17:35:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3342/
CommitID: 9e045f6

joshpalis added 8 commits September 8, 2022 21:41

Adding support to transport environment settings to extensions and up…

d9edbcc

…dated unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com>

Merge branch 'feature/extensions' into create-components

c9660bb

Merge branch 'feature/extensions' into create-components

f125381

added in environment settings instead of settings

fd0b878

Signed-off-by: Joshua Palis <jpalis@amazon.com>

Updated support for environment settings, now extensions will send ov…

ef0e83e

…er settings from which they would like to retrieve values for Signed-off-by: Joshua Palis <jpalis@amazon.com>

fixing component key list serialization error

e451328

Signed-off-by: Joshua Palis <jpalis@amazon.com>

Merge branch 'feature/extensions' into create-components

d4bc0f2

Adding initial support for AddSettingUpdateConsumers for extensions. …

097b239

…Draft, as getSettings support still needs to be finalized Signed-off-by: Joshua Palis <jpalis@amazon.com>

joshpalis mentioned this pull request Sep 14, 2022

[Feature/extensions] Adding support for Extension Create Components [environment settings and add setting update consumers] opensearch-project/opensearch-sdk-java#138

Merged

Updated implementation in preparation for getSettings support integra…

fab1cf8

…tion Signed-off-by: Joshua Palis <jpalis@amazon.com>

joshpalis added 2 commits September 15, 2022 17:30

fixing syntax

d9188d8

Signed-off-by: Joshua Palis <jpalis@amazon.com>

Updating environemnt settings name to initialEnvironmentSettings in o…

e05ada9

…rder to make this setting object source clear Signed-off-by: Joshua Palis <jpalis@amazon.com>

dbwiddis mentioned this pull request Sep 16, 2022

[Feature/extensions] Add getSettings support for AD #4519

Merged

6 tasks

joshpalis added 2 commits September 16, 2022 19:28

updating comments for getSettings integration

40fc4af

Signed-off-by: Joshua Palis <jpalis@amazon.com>

Merge branch 'feature/extensions' into create-components

fefb67c

joshpalis changed the title ~~Adding support for Extension Create Components [environment settings and add setting update consumers]~~ [Feature/extensions] Adding support for Extension Create Components [environment settings and add setting update consumers] Sep 16, 2022

Integrated writeable settings support

567a0ab

Signed-off-by: Joshua Palis <jpalis@amazon.com>

joshpalis requested review from dbwiddis and owaiskazi19 September 16, 2022 22:55

dbwiddis requested changes Sep 17, 2022

View reviewed changes

server/src/main/java/org/opensearch/env/EnvironmentSettingsResponse.java Show resolved Hide resolved

owaiskazi19 reviewed Sep 19, 2022

View reviewed changes

server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java Outdated Show resolved Hide resolved

owaiskazi19 reviewed Sep 19, 2022

View reviewed changes

server/src/main/java/org/opensearch/extensions/UpdateSettingsResponseHandler.java Show resolved Hide resolved

joshpalis requested a review from saratvemulapalli September 19, 2022 23:31

joshpalis added 2 commits September 20, 2022 16:10

rebase with feature/extensions, fixing merge conflicts

96744dd

Signed-off-by: Joshua Palis <jpalis@amazon.com>

fixing testRegisterHandler

0c4abfa

Signed-off-by: Joshua Palis <jpalis@amazon.com>

spotlessApply

45bfb9d

Signed-off-by: Joshua Palis <jpalis@amazon.com>

joshpalis requested a review from dbwiddis September 20, 2022 18:10

dbwiddis approved these changes Sep 20, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

joshpalis requested a review from owaiskazi19 September 20, 2022 23:39

updating changelong so that it points to the pull request rather than…

26362e4

… the issue Re-run gradle check Signed-off-by: Joshua Palis <jpalis@amazon.com>

joshpalis added 2 commits September 22, 2022 20:03

moving request handlers to seperate classes

f1d0d0d

Signed-off-by: Joshua Palis <jpalis@amazon.com>

fixing environmentsettings unit test

2aec9ec

Signed-off-by: Joshua Palis <jpalis@amazon.com>

spotlessApply

1237ebd

Signed-off-by: Joshua Palis <jpalis@amazon.com>

owaiskazi19 reviewed Sep 22, 2022

View reviewed changes

server/src/test/java/org/opensearch/extensions/ExtensionsOrchestratorTests.java Outdated Show resolved Hide resolved

owaiskazi19 reviewed Sep 22, 2022

View reviewed changes

server/src/main/java/org/opensearch/extensions/AddSettingsUpdateConsumerRequestHandler.java Show resolved Hide resolved

owaiskazi19 approved these changes Sep 22, 2022

View reviewed changes

joshpalis requested review from saratvemulapalli and removed request for saratvemulapalli September 23, 2022 15:41

Moved extensionNode intiialization in setup()

9e045f6

Signed-off-by: Joshua Palis <jpalis@amazon.com>

owaiskazi19 merged commit dec1e58 into opensearch-project:feature/extensions Sep 23, 2022

ryanbogan mentioned this pull request Nov 17, 2022

[Feature/extensions] Merge to main tracking - getSettings() support, ActionListener onFailure(), and initial createComponents support #5272

Closed

Conversation

joshpalis commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Sep 14, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 15, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 15, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 15, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 16, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 16, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 16, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

dbwiddis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

github-actions bot commented Sep 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 21, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

owaiskazi19 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 22, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 23, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

joshpalis commented Sep 14, 2022 •

edited

Loading

codecov-commenter commented Sep 14, 2022 •

edited

Loading