[Feature/extensions] Catch up feature/extensions branch CHANGELOG#4479
Merged
owaiskazi19 merged 1 commit intoopensearch-project:feature/extensionsfrom Sep 14, 2022
Merged
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
reviewed
Sep 11, 2022
| - Resolved javadoc error ([#3380](https://github.com/opensearch-project/OpenSearch/pull/3380)) | ||
| - Read from extensions.yml ([#3381](https://github.com/opensearch-project/OpenSearch/pull/3381)) | ||
| - Added unit tests and modified extension read logic for ExtensionsOrchestrator ([#3449](https://github.com/opensearch-project/OpenSearch/pull/3449)) | ||
| - Removed Plugin Directory code from ExtensionsOrchestrator ([#3721](https://github.com/opensearch-project/OpenSearch/pull/3721)) |
Member
There was a problem hiding this comment.
Isn't this should be under Removed?
Member
Author
There was a problem hiding this comment.
Isn't this should be under
Removed?
Good question. I'm not really sure. Some thoughts:
- The Keep a Changelog link that inspires our change log notes that the log should be curated -- otherwise it's no different than a commit diff (from which I sourced this list). I anticipate that there will be a curation step between the current state and the eventual inclusion in the release notes.
- In my view the purpose of a change log is to note changes. Work on a feature branch is primarily "new" work, thus my choice to include the entire list in "added". In my view "removed" would be something that was removed from a previous version of OpenSearch. So the only thing in this list that would fall under "removed" is actual OpenSearch functionality that is changed. In this particular case we're just updating one of the files we added in an earlier PR, so this particular line will probably be curated out (or the PR # combined with an earlier line grouping all actions on the ExtensionsOrchestrator together).
Would appreciate continued discussion in a more general case on #4477 where I will copy this comment.
Member
There was a problem hiding this comment.
This makes sense. There might be a case later where we will remove some functionality from OpenSearch as well. Do you think we can have Removed for such cases?
Member
Author
There was a problem hiding this comment.
Yes, if we removed some functionality from OpenSearch it would most definitely be in "removed".
Member
There was a problem hiding this comment.
What do we think about compressing multiple entries into one?
Consider
- Added thing to bar [PR1] [PR2]
Instead of
- Moved thing to bar [PR2]
- Added thing to foo [PR1]
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
Sep 12, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
saratvemulapalli
approved these changes
Sep 13, 2022
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catches up the changelog for
feature/extensionsbranch with all merged (and non-reverted) PRs.Issues Resolved
See discussion on #4477
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.