Skip to content

[Backport 1.x] Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space.#4470

Merged
reta merged 2 commits intoopensearch-project:1.xfrom
peterzhuamazon:backport-4362-1.x
Sep 9, 2022
Merged

[Backport 1.x] Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space.#4470
reta merged 2 commits intoopensearch-project:1.xfrom
peterzhuamazon:backport-4362-1.x

Conversation

@peterzhuamazon
Copy link
Copy Markdown
Member

@peterzhuamazon peterzhuamazon commented Sep 9, 2022

Description

Backport #4362 1.x

Issues Resolved

#4362

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Sep 9, 2022
@peterzhuamazon peterzhuamazon requested review from a team and reta as code owners September 9, 2022 18:03
@peterzhuamazon peterzhuamazon changed the base branch from main to 1.x September 9, 2022 18:03
@peterzhuamazon peterzhuamazon changed the title Backport #4362 1.x [Backport 1.x] Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space. Sep 9, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Copy Markdown
Contributor

reta commented Sep 9, 2022

@peterzhuamazon we need #4382 to get in :(

@reta
Copy link
Copy Markdown
Contributor

reta commented Sep 9, 2022

@peterzhuamazon could you rebase please?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 6f17abd into opensearch-project:1.x Sep 9, 2022
@peterzhuamazon peterzhuamazon deleted the backport-4362-1.x branch September 12, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants