[Backport 2.x] [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica#4396
Merged
dreamer-89 merged 2 commits intoopensearch-project:2.xfrom Sep 5, 2022
Conversation
…d primary on onNewCheckpoint on replica (opensearch-project#4363) * [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments 2 Signed-off-by: Suraj Singh <surajrider@gmail.com> * Test failures Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #4396 +/- ##
============================================
+ Coverage 70.54% 70.61% +0.06%
- Complexity 56942 57126 +184
============================================
Files 4572 4584 +12
Lines 273816 274497 +681
Branches 40152 40226 +74
============================================
+ Hits 193170 193833 +663
+ Misses 64455 64431 -24
- Partials 16191 16233 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mch2
approved these changes
Sep 3, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
Author
|
503 error during ping on github adoptium binary release. Will retry gradle check after some time. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
Author
|
This test was added as part of PR #4363. Looking into it. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
For another seed - #4366 (comment) |
Member
Author
Raised #4414 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manul backport of #4363 to 2.x