[Feature/extensions] Only send one extension info when initializing by dbwiddis · Pull Request #4302 · opensearch-project/OpenSearch

dbwiddis · 2022-08-25T22:22:15Z

Companion PR: opensearch-project/opensearch-sdk-java#103

Description

Sends a single DiscoveryExtension object when initializing an extension, rather than the entire list.

Issues Resolved

Fixes opensearch-project/opensearch-sdk-java#93

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-08-25T22:35:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2120/
CommitID: dd037b1f29a7e5749312974ef18ab9d68a95f9de

github-actions · 2022-08-26T05:39:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2132/
CommitID: 6e0c784af3b585c3e4db8dda6ca1d8d1a98df370

Signed-off-by: Daniel Widdis <widdis@gmail.com>

github-actions · 2022-08-26T06:08:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2134/
CommitID: d0abb01

owaiskazi19 · 2022-08-26T07:27:53Z

server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java

+                        DiscoveryExtension discoveryExtension = new DiscoveryExtension(
                            extension.getName(),
-                            extension.getDescription(),
-                            extension.getVersion(),


Why are we not considering Description and Version of the extension?

Okay I see. We are getting it from PluginInfo. Ignore my comment here

For clarity (and for other reviewers), there are no changes to this try/catch code block other than the indentation caused by the else. Github's diff is confused. :-)

saratvemulapalli · 2022-08-26T16:48:17Z

server/src/main/java/org/opensearch/discovery/InitializeExtensionsRequest.java

-     * TODO change DiscoveryNode to Extension information
-     */
-    private final List<DiscoveryExtension> extensions;
+    private final DiscoveryExtension extension;


The initial intention for this was to help the extension understand which extensions are installed in the system.
If the dependencies of extension being initialized don't exist, it should fail the init.

I love this simple approach not thinking too far ahead, @dbwiddis could you open an issue to design how can extensions discover if its dependencies exist.

Exist and are initialized.... something the orchestrator knows... but we don't yet have a "depends on" field in extensions or which field (uniqueID?) is used to ID that other extension. I'll open a tracking issue as still many unknowns there.

saratvemulapalli · 2022-08-26T23:02:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/2134/

CommitID: d0abb01

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':plugins:analysis-icu:compileInternalClusterTestJava'.
> Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':modules:lang-expression:compileInternalClusterTestJava'.
> java.lang.OutOfMemoryError: Java heap space

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

github-actions · 2022-08-26T23:29:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2164/
CommitID: d0abb01

github-actions · 2022-08-27T00:01:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/2167/
CommitID: d0abb01

dbwiddis requested review from a team and reta as code owners August 25, 2022 22:22

dbwiddis mentioned this pull request Aug 25, 2022

Only send one extension info when initializing opensearch-project/opensearch-sdk-java#103

Merged

dbwiddis requested review from owaiskazi19 and ryanbogan August 25, 2022 22:23

dbwiddis force-pushed the initOneExtension branch from dd037b1 to 6e0c784 Compare August 26, 2022 05:26

Only send one extension info when initializing

d0abb01

Signed-off-by: Daniel Widdis <widdis@gmail.com>

dbwiddis force-pushed the initOneExtension branch from 6e0c784 to d0abb01 Compare August 26, 2022 05:53

owaiskazi19 reviewed Aug 26, 2022

View reviewed changes

owaiskazi19 approved these changes Aug 26, 2022

View reviewed changes

dbwiddis requested a review from saratvemulapalli August 26, 2022 16:44

saratvemulapalli reviewed Aug 26, 2022

View reviewed changes

saratvemulapalli approved these changes Aug 26, 2022

View reviewed changes

saratvemulapalli merged commit 7841e3d into opensearch-project:feature/extensions Aug 27, 2022

dbwiddis deleted the initOneExtension branch October 6, 2022 17:12

ryanbogan mentioned this pull request Nov 17, 2022

[Feature/extensions] Merge to main tracking - Extension Points, initial REST implementation and registering Transport Actions #5271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/extensions] Only send one extension info when initializing#4302

[Feature/extensions] Only send one extension info when initializing#4302
saratvemulapalli merged 1 commit intoopensearch-project:feature/extensionsfrom
dbwiddis:initOneExtension

dbwiddis commented Aug 25, 2022

Uh oh!

github-actions bot commented Aug 25, 2022

Uh oh!

github-actions bot commented Aug 26, 2022

Uh oh!

github-actions bot commented Aug 26, 2022

Uh oh!

owaiskazi19 Aug 26, 2022

Uh oh!

owaiskazi19 Aug 26, 2022

Uh oh!

dbwiddis Aug 26, 2022 •

edited

Loading

Uh oh!

saratvemulapalli Aug 26, 2022

Uh oh!

dbwiddis Aug 26, 2022

Uh oh!

saratvemulapalli commented Aug 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 26, 2022

Uh oh!

github-actions bot commented Aug 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dbwiddis commented Aug 25, 2022

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Aug 25, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

owaiskazi19 Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

dbwiddis Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saratvemulapalli Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

dbwiddis Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

saratvemulapalli commented Aug 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dbwiddis Aug 26, 2022 •

edited

Loading