issue #28 Rename to extensions by mloufra · Pull Request #4063 · opensearch-project/OpenSearch

mloufra · 2022-08-01T07:17:00Z

Signed-off-by: mloufra mloufra@amazon.com

Description

Rename method names, class names, variable names from plugin to extensions in the sdk codebase and related OpenSearch code

Equivalent PR on SDK: opensearch-project/opensearch-sdk-java#72

Issues Resolved

opensearch-project/opensearch-sdk-java#28

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-08-01T07:41:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1167/
CommitID: b806e04dccb57c1a0298780ab8816cd3ee938ca5

github-actions · 2022-08-05T17:55:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1494/
CommitID: b806e04dccb57c1a0298780ab8816cd3ee938ca5

github-actions · 2022-08-09T20:02:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1628/
CommitID: a120dd2

codecov-commenter · 2022-08-09T20:03:31Z

Codecov Report

Merging #4063 (5252bf5) into feature/extensions (716756a) will decrease coverage by 0.08%.
The diff coverage is 41.66%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4063      +/-   ##
========================================================
- Coverage                 70.64%   70.56%   -0.09%     
+ Complexity                57129    57074      -55     
========================================================
  Files                      4612     4612              
  Lines                    274811   274812       +1     
  Branches                  40227    40227              
========================================================
- Hits                     194142   193921     -221     
- Misses                    64407    64643     +236     
+ Partials                  16262    16248      -14

Impacted Files	Coverage Δ
...search/discovery/InitializeExtensionsResponse.java	`0.00% <0.00%> (ø)`
...nsearch/discovery/InitializeExtensionsRequest.java	`40.00% <33.33%> (ø)`
.../opensearch/extensions/ExtensionsOrchestrator.java	`74.21% <80.00%> (+0.16%)`	⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java	`0.00% <0.00%> (-75.00%)`	⬇️
...readonly/TransportVerifyShardIndexBlockAction.java	`9.75% <0.00%> (-73.18%)`	⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java	`17.85% <0.00%> (-53.58%)`	⬇️
...ch/transport/ReceiveTimeoutTransportException.java	`50.00% <0.00%> (-50.00%)`	⬇️
.../index/shard/IndexShardNotRecoveringException.java	`0.00% <0.00%> (-50.00%)`	⬇️
.../opensearch/client/indices/CloseIndexResponse.java	`48.75% <0.00%> (-42.50%)`	⬇️
...indices/readonly/TransportAddIndexBlockAction.java	`20.68% <0.00%> (-41.38%)`	⬇️
... and 458 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-09T20:18:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1629/
CommitID: ae213d36986eda52601ab44bda5cdffc85455796

github-actions · 2022-08-09T20:23:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1630/
CommitID: 8a263ebc3913cb606c5c69d581625b18da93ec7f

Signed-off-by: mloufra <mloufra@amazon.com>

github-actions · 2022-08-09T23:04:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1637/
CommitID: 9d8bc5dfff82dcee8cf5c5f2e7d09327b06f7889

github-actions · 2022-08-09T23:20:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1638/
CommitID: c69897d34623307d45b102740ef10cd136576844

owaiskazi19 · 2022-08-09T23:50:43Z

Suggested change

* InitializeExtensionsRequest to intialize plugin

* InitializeExtensionsRequest to initialize extension

owaiskazi19 · 2022-08-09T23:51:17Z

Suggested change

* InitializeExtensionsResponse to intialize plugin

* InitializeExtensionsResponse to initialize extension

Signed-off-by: mloufra <mloufra@amazon.com>

github-actions · 2022-08-10T00:27:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1640/
CommitID: 9d8bc5dfff82dcee8cf5c5f2e7d09327b06f7889

github-actions · 2022-08-10T00:28:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1641/
CommitID: c51c292923fbffea003426c3525e917779598dbd

github-actions · 2022-08-10T00:33:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1642/
CommitID: 9d8bc5dfff82dcee8cf5c5f2e7d09327b06f7889

github-actions · 2022-08-10T00:39:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1643/
CommitID: 67637cd34b0cb54412482b1d2a4622692f319bf5

Signed-off-by: mloufra <mloufra@amazon.com>

github-actions · 2022-08-10T18:28:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1665/
CommitID: 93e8f899f937684c71a680e4d3627d3c33decf75

github-actions · 2022-08-10T18:38:36Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1666/
CommitID: abbe26f

Signed-off-by: mloufra <mloufra@amazon.com>

github-actions · 2022-08-10T20:01:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1668/
CommitID: 5252bf5

owaiskazi19

LGTM

mloufra requested review from a team and reta as code owners August 1, 2022 07:17

mloufra mentioned this pull request Aug 1, 2022

Rename to Extensions opensearch-project/opensearch-sdk-java#72

Merged

mloufra force-pushed the feature2 branch 3 times, most recently from ae213d3 to 8a263eb Compare August 9, 2022 19:55

ryanbogan approved these changes Aug 9, 2022

View reviewed changes

mloufra force-pushed the feature2 branch from 8a263eb to 9d8bc5d Compare August 9, 2022 22:38

mloufra added 2 commits August 9, 2022 22:47

rebase the lastest commit

53e4d6b

Signed-off-by: mloufra <mloufra@amazon.com>

rebase the lastest commit

be06ed2

Signed-off-by: mloufra <mloufra@amazon.com>

owaiskazi19 reviewed Aug 9, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java Outdated

Rename fail message to extensions

2d45db1

Signed-off-by: mloufra <mloufra@amazon.com>

mloufra force-pushed the feature2 branch 2 times, most recently from c51c292 to 9d8bc5d Compare August 10, 2022 00:06

mloufra force-pushed the feature2 branch from 67637cd to 93e8f89 Compare August 10, 2022 18:19

Rename remain plugin to extensions

abbe26f

Signed-off-by: mloufra <mloufra@amazon.com>

mloufra force-pushed the feature2 branch from 93e8f89 to abbe26f Compare August 10, 2022 18:26

fix the method name

5252bf5

Signed-off-by: mloufra <mloufra@amazon.com>

owaiskazi19 approved these changes Aug 10, 2022

View reviewed changes

owaiskazi19 merged commit ff2846a into opensearch-project:feature/extensions Aug 10, 2022

ryanbogan mentioned this pull request Nov 17, 2022

[Feature/extensions] Merge to main tracking - Extension Points, initial REST implementation and registering Transport Actions #5271

Closed

	* InitializeExtensionsRequest to intialize plugin
	* InitializeExtensionsRequest to initialize extension

	* InitializeExtensionsResponse to intialize plugin
	* InitializeExtensionsResponse to initialize extension

Conversation

mloufra commented Aug 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 5, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

owaiskazi19 Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

owaiskazi19 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mloufra commented Aug 1, 2022 •

edited

Loading

codecov-commenter commented Aug 9, 2022 •

edited

Loading