[Backport 2.x] Move bash flag to set statement#3519
Merged
owaiskazi19 merged 1 commit intoopensearch-project:2.xfrom Jun 6, 2022
shdubsh:backport/backport-3494-to-2.x
Merged
[Backport 2.x] Move bash flag to set statement#3519owaiskazi19 merged 1 commit intoopensearch-project:2.xfrom shdubsh:backport/backport-3494-to-2.x
owaiskazi19 merged 1 commit intoopensearch-project:2.xfrom
shdubsh:backport/backport-3494-to-2.x
Conversation
Passing bash with flags to the first argument of /usr/bin/env requires its own flag to interpret it correctly. Rather than use `env -S` to split the argument, have the script `set -e` to enable the same behavior explicitly in preinst and postinst scripts. Also set `-o pipefail` for consistency. Closes: #3492 Signed-off-by: Cole White <cwhite@wikimedia.org>
Member
|
#1703 for the above |
Member
|
start gradle check |
reta
approved these changes
Jun 6, 2022
owaiskazi19
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 2fbf335 from #3494