Skip to content

Fixing publishZip publication by adding the dependency to generatePomFileForNebulaPublication#3183

Closed
reta wants to merge 1 commit intoopensearch-project:mainfrom
reta:fix.publishzip
Closed

Fixing publishZip publication by adding the dependency to generatePomFileForNebulaPublication#3183
reta wants to merge 1 commit intoopensearch-project:mainfrom
reta:fix.publishzip

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented May 4, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Fixing publishZip publication by adding the dependency to generatePomFileForNebulaPublication, the issue manifested in opensearch-project/opensearch-plugin-template-java#31:

> Task :publishPluginZipPublicationToZipStagingRepository
Execution optimizations have been disabled for task ':publishPluginZipPublicationToZipStagingRepository' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: 'opensearch-plugin-template-java/build/distributions/rename-unspecified.pom'. Reason: Task ':publishPluginZipPublicationToZipStagingRepository' uses this output of task ':generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Fixing publishZip publication by adding the dependency to generatePom…
3cf0163 
…FileForNebulaPublication

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta requested a review from a team as a code owner May 4, 2022 18:07
@reta reta added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels May 4, 2022
@reta
Copy link
Copy Markdown
Contributor Author

reta commented May 4, 2022

@prudhvigodithi could you please take a look? (address one of the issues).

@reta reta added v2.0.0 Version 2.0.0 v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0 labels May 4, 2022
@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

opensearch-ci-bot commented May 4, 2022

✅   Gradle Check success 3cf0163
Log 5000

Reports 5000

@prudhvigodithi
Copy link
Copy Markdown
Member

prudhvigodithi commented May 4, 2022 •
edited
Loading

Hey @reta, can you please specify, how did you invoke the task, for me publishPluginZipPublicationToZipStagingRepository say SUCCESSFUL, but what throws warning is ./gradlew build, are we on the same page ?

[opensearch@11827a526d02 opensearch-plugin-template-java]$ ./gradlew publishPluginZipPublicationToZipStagingRepository
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Linux 5.4.186-113.361.amzn2int.x86_64 (amd64)
  JDK Version           : 17 (Eclipse Temurin JDK)
  JAVA_HOME             : /usr/lib/jvm/adoptopenjdk-14-hotspot
  Random Testing Seed   : AC054586B1C8F365
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 1s

@reta
Copy link
Copy Markdown
Contributor Author

reta commented May 4, 2022

Hey @reta, can you please specify, how did you invoke the task, for me publishPluginZipPublicationToZipStagingRepository say SUCCESSFUL, but what throws warning is ./gradlew build, are we on the same page ?

./gradlew clean build publishPluginZipPublicationToZipStagingRepository

@prudhvigodithi prudhvigodithi mentioned this pull request May 4, 2022
Merged
5 tasks
@prudhvigodithi
Copy link
Copy Markdown
Member

prudhvigodithi commented May 4, 2022 •
edited
Loading

@reta thanks for the clue, can you please check/test the PR I have made it little better address issues with both the tasks publishPluginZipPublicationToZipStagingRepository and validatePluginZipPom.
https://github.com/opensearch-project/OpenSearch/pull/3189/files

dblock
dblock approved these changes May 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to merge this @prudhvigodithi ?

@prudhvigodithi
Copy link
Copy Markdown
Member

prudhvigodithi commented May 5, 2022 •
edited
Loading

Hey @dblock, I have created an another PR that fixes both the tasks publishPluginZipPublicationToZipStagingRepository & validatePluginZipPom dependency issues (Plus added some tests as well.)
PR : #3189
@reta added some feedback there and once we merge the other PR, we need not merge this PR as above PR address the Fix.

@dblock
Copy link
Copy Markdown
Member

dblock commented May 5, 2022

Closing in favor of #3189

@dblock dblock closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch v2.0.0 Version 2.0.0 v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reta @opensearch-ci-bot @prudhvigodithi @dblock