[Backport 2.x] [Javadoc] Add missing package-info.java files to server#3129
[Backport 2.x] [Javadoc] Add missing package-info.java files to server#3129
Conversation
In preparation for re-enabling the missingJavadoc gradle task this change adds in the missing package-info.java files to the server folder. For now general javadocs are added to these files with the intent to clean up with better descriptions over time. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 2146827)
|
@nknize s'up your DCO always fails on backports? |
I wonder if it's because I use my own GPG key instead of default github to sign commits? We might want to check the backport action. |
|
I have my own gpg key too. |
|
No idea then. Maybe DCO check doesn't like my commits opened by anyone other than me? 😂 I always have to check out the backport branch and amend the commit. It's a pain. |
It would be because your DCO sign off is |
|
@nknize I've set the DCO check to pass. You are free to merge as far as the CI checks go! |
|
Thank you @peternied
Thanks for clarifying @VachaShah! My apache gpg key needs my full name to match. Is there any way the DCO workflow can pull the name from the original author sign-off instead of github display name? |
What do you click to do this? |

Backport 2146827 from #3128