Deprecate setting 'cluster.initial_master_nodes' and introduce the alternative setting 'cluster.initial_cluster_manager_nodes' by tlfeng · Pull Request #2463 · opensearch-project/OpenSearch

tlfeng · 2022-03-14T18:37:47Z

Description

Add a new setting cluster.initial_cluster_manager_nodes, aims to replace the existing cluster.initial_master_nodes
Set the value of the old setting cluster.initial_master_nodes as the fallback to the new setting
Deprecate the existing setting cluster.initial_master_nodes
Add unit tests

Reference: commit 63c75d1 / PR #2221

Deprecation notice:
With the built-in deprecation logger of OpenSearch (code), the following message will be recorded in the log files:
In logs/opensearch_deprecation.log:
[2022-03-07T20:48:57,158][DEPRECATION][o.o.d.c.s.Settings ] [ip-100-00-00-000] [cluster.initial_master_nodes] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
In logs/opensearch_deprecation.json:
{"type": "deprecation", "timestamp": "2022-03-07T20:48:57,158Z", "level": "DEPRECATION", "component": "o.o.d.c.s.Settings", "cluster.name": "opensearch", "node.name": "ip-100-00-00-000", "message": "[cluster.initial_master_nodes] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version." }

Issues Resolved

Part of #1549

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…er.initial_cluster_manager_nodes Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T18:38:03Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-03-14T18:58:07Z

❌ Gradle Check failure 4ea1231
Log 3351

Reports 3351

…r_nodes Signed-off-by: Tianli Feng <ftianli@amazon.com>

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T20:50:34Z

❌ Gradle Check failure 11646a4
Log 3358

Reports 3358

tlfeng · 2022-03-14T20:53:50Z

In log 3358:

> Task :qa:rolling-upgrade:v1.3.0#oldClusterTest

=== Standard output of node `node{:qa:rolling-upgrade:v1.3.0-0}` ===

»    ↓ errors and warnings from /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/qa/rolling-upgrade/build/testclusters/v1.3.0-0/logs/opensearch.stdout.log ↓
» ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [v1.3.0-0] uncaught exception in thread [main]
»  org.opensearch.bootstrap.StartupException: java.lang.IllegalArgumentException: unknown setting [cluster.initial_cluster_manager_nodes] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
»  	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:182) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:169) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:100) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) ~[opensearch-cli-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.cli.Command.main(Command.java:101) ~[opensearch-cli-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:135) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:101) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  Caused by: java.lang.IllegalArgumentException: unknown setting [cluster.initial_cluster_manager_nodes] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
»  	at org.opensearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:589) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:530) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:500) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:470) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.common.settings.SettingsModule.<init>(SettingsModule.java:161) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.node.Node.<init>(Node.java:463) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.node.Node.<init>(Node.java:319) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:412) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:178) ~[opensearch-1.3.0-SNAPSHOT.jar:1.3.0-SNAPSHOT]
»  	... 6 more

opensearch-ci-bot · 2022-03-14T20:56:24Z

❌ Gradle Check failure 1fa949c
Log 3359

Reports 3359

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T21:36:53Z

❌ Gradle Check failure 7b09e6c539ee08cd3e1701c441d2725a95fd3d88
Log 3360

Reports 3360

opensearch-ci-bot · 2022-03-14T21:42:42Z

❌ Gradle Check failure 04ced0d
Log 3361

Reports 3361

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T22:21:44Z

❌ Gradle Check failure cf22874
Log 3364

Reports 3364

tlfeng · 2022-03-14T22:25:26Z

In log 3364:

> Task :qa:remote-clusters:integTest

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=373CDFD0EF8BD8AA -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=nb-NO -Dtests.timezone=Canada/Saskatchewan -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([373CDFD0EF8BD8AA:304A0A1BD40DAEF7]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in issue #1703

tlfeng · 2022-03-15T03:30:40Z

start gradle check

opensearch-ci-bot · 2022-03-15T04:15:11Z

❌ Gradle Check failure cf22874
Log 3382

Reports 3382

tlfeng · 2022-03-15T04:17:39Z

In log 3382:

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.3.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}" -Dtests.seed=39544BF2007F84D3 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=cs -Dtests.timezone=Brazil/DeNoronha -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does} FAILED
    java.lang.AssertionError: Failure at [indices.get_field_mapping/20_missing_field:20]: field [test_index.mappings] is null
        at __randomizedtesting.SeedInfo.seed([39544BF2007F84D3:B1007428AE83E92B]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)
...

It's tracked in issue #2440

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-15T07:23:31Z

✅ Gradle Check success 7d96d3f
Log 3391

Reports 3391

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-16T04:37:46Z

✅ Gradle Check success 82ec6a0
Log 3428

Reports 3428

opensearch-ci-bot · 2022-03-16T05:05:35Z

❌ Gradle Check failure 975501f
Log 3431

Reports 3431

tlfeng · 2022-03-16T05:37:00Z

In log 3431:

> Task :qa:remote-clusters:integTest
REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=EA345535C521FDAD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=tr-TR -Dtests.timezone=Europe/Moscow -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([EA345535C521FDAD:ED4280FEFEA78BF0]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)
...

It's reported in issue #1703

Signed-off-by: Tianli Feng <ftianli@amazon.com>

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com> # Conflicts: # test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java

opensearch-ci-bot · 2022-03-16T21:11:16Z

✅ Gradle Check success 1afb92b
Log 3457

Reports 3457

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com>

…ster_nodes into an error message of BootstrapChecks Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-17T00:52:49Z

✅ Gradle Check success 2ee85da
Log 3466

Reports 3466

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-17T08:29:23Z

❌ Gradle Check failure 7fc7c62
Log 3476

Reports 3476

opensearch-ci-bot · 2022-03-17T08:48:06Z

✅ Gradle Check success bd7fdbe
Log 3477

Reports 3477

Deprecate setting cluster.initial_master_nodes, and add setting clust…

4ea1231

…er.initial_cluster_manager_nodes Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng requested a review from a team as a code owner March 14, 2022 18:37

tlfeng added enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0 documentation pending Tracks issues which have PRs merged but documentation changes pending labels Mar 14, 2022

tlfeng mentioned this pull request Mar 14, 2022

Add alternative usages for the REST APIs and configurations that contain "master" terminology #1549

Closed

12 tasks

Tianli Feng added 2 commits March 14, 2022 13:31

Rename cluster.initial_master_nodes to cluster.initial_cluster_manage…

11646a4

…r_nodes Signed-off-by: Tianli Feng <ftianli@amazon.com>

Replace master-eligible to cluster-manager-eligible in opensearch.yml

1fa949c

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng force-pushed the setting-initial-master-node branch from 45ae584 to 7b09e6c Compare March 14, 2022 21:13

Fix bwc test by configuring setting name

04ced0d

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng force-pushed the setting-initial-master-node branch from 7b09e6c to 04ced0d Compare March 14, 2022 21:16

Correct a setting name in docker-compose

cf22874

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Merge remote-tracking branch 'upstream/main' into setting-initial-mas…

7d96d3f

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com>

dblock requested a review from andrross March 15, 2022 15:49

andrross removed their request for review March 15, 2022 19:14

kotwanikunal self-assigned this Mar 15, 2022

kotwanikunal self-requested a review March 15, 2022 20:49

Tianli Feng added 4 commits March 15, 2022 20:17

Revert changing an error message in bootstrapchecks

e00348e

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Show correct setting name in exception message

03e29f8

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Flip arguments in assertEquals(), because the first is expected value

82ec6a0

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Rename initialMasterNodes in test method name

975501f

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Tianli Feng added 3 commits March 16, 2022 11:49

Merge branch 'main' into setting-initial-master-node

3d1cd8e

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Use Settings.existsOrFallbackExists() instead of exists()

754cd1a

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Merge remote-tracking branch 'upstream/main' into setting-initial-mas…

1afb92b

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com> # Conflicts: # test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java

kartg approved these changes Mar 16, 2022

View reviewed changes

Tianli Feng added 2 commits March 16, 2022 16:52

Merge remote-tracking branch 'upstream/main' into setting-initial-mas…

c967ad4

…ter-node Signed-off-by: Tianli Feng <ftianli@amazon.com>

Add both cluster.initial_cluster_manager_nodes and cluster.initial_ma…

2ee85da

…ster_nodes into an error message of BootstrapChecks Signed-off-by: Tianli Feng <ftianli@amazon.com>

Tianli Feng added 2 commits March 17, 2022 00:38

Update import not to use asterisk

7fc7c62

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Add the missing import of INITIAL_CLUSTER_MANAGER_NODES_SETTING

bd7fdbe

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng mentioned this pull request Mar 18, 2022

Use Hamcrest matchers and assertThat() in ReindexRenamedSettingTests to improve readability #2503

Merged

5 tasks

tlfeng merged commit 19eadb4 into opensearch-project:main Mar 18, 2022

tlfeng deleted the setting-initial-master-node branch March 18, 2022 21:55

This was referenced Sep 13, 2022

Update docker-compose.yml opensearch-project/project-website#992

Merged

Update docker-compose.yml. opensearch-project/opensearch-build#2612

Merged

Update docker compose opensearch-project/documentation-website#1194

Merged

sandeshkr419 mentioned this pull request Feb 16, 2023

[BUG] _cluster/stats API returning incorrect cluster_manager count #6103

Closed

Conversation

tlfeng commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

tlfeng commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

opensearch-ci-bot commented Mar 14, 2022

Uh oh!

tlfeng commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tlfeng commented Mar 15, 2022

Uh oh!

opensearch-ci-bot commented Mar 15, 2022

Uh oh!

tlfeng commented Mar 15, 2022

Uh oh!

opensearch-ci-bot commented Mar 15, 2022

Uh oh!

opensearch-ci-bot commented Mar 16, 2022

Uh oh!

opensearch-ci-bot commented Mar 16, 2022

Uh oh!

tlfeng commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opensearch-ci-bot commented Mar 16, 2022

Uh oh!

opensearch-ci-bot commented Mar 17, 2022

Uh oh!

opensearch-ci-bot commented Mar 17, 2022

Uh oh!

opensearch-ci-bot commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tlfeng commented Mar 14, 2022 •

edited

Loading

tlfeng commented Mar 14, 2022 •

edited

Loading

tlfeng commented Mar 16, 2022 •

edited

Loading