Add mapper_settings support and field_mapping mapper type for pull-based ingestion#20722
Conversation
…sed ingestion Signed-off-by: Rishab Nahata <rishab.nahata@uber.com>
PR Reviewer Guide 🔍(Review updated until commit a94a723)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to a94a723 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit cbf8280
Suggestions up to commit 4655f27
Suggestions up to commit eab96bb
Suggestions up to commit 4e13480
|
|
❌ Gradle check result for 4e13480: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <rishab.nahata@uber.com>
|
Persistent review updated to latest commit eab96bb |
|
❌ Gradle check result for eab96bb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <rishab.nahata@uber.com>
|
❌ Gradle check result for 4655f27: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <rishab.nahata@uber.com>
|
❌ Gradle check result for cbf8280: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/cluster/metadata/MetadataCreateIndexServiceTests.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/mappers/IngestionMessageMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishab Nahata <rishabnahata07@gmail.com>
|
Persistent review updated to latest commit a94a723 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20722 +/- ##
============================================
+ Coverage 73.23% 73.28% +0.04%
- Complexity 72016 72019 +3
============================================
Files 5783 5784 +1
Lines 329438 329471 +33
Branches 47534 47541 +7
============================================
+ Hits 241268 241440 +172
+ Misses 68868 68613 -255
- Partials 19302 19418 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varunbharadwaj
left a comment
There was a problem hiding this comment.
Looks good to me.
Description
Adds a new
mapper_settings.*prefix setting toIngestionSourcethat allows mapper-specific configuration to be passed to message mappers in pull-based ingestion. Also addsfield_mappingas a newMapperTypeenum value with a version compatibility check to prevent usage in mixed clusters.This is a foundational change — the settings are stored but not yet consumed. The actual
FieldMappingIngestionMessageMapperimplementation will follow in a subsequent PR.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#20721
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.