Switch gRPC transport from grpc-netty-shaded to grpc-netty#20632
Switch gRPC transport from grpc-netty-shaded to grpc-netty#20632bowenlan-amzn wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e1f80bc to
5255124
Compare
|
❗ AI-powered Code-Diff-Analyzer found issues on commit 5255124.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
5255124 to
2c3187b
Compare
|
@github-actions commented on Feb 14, 2026, 9:40 PM PST:
The analyzer flagged permission java.lang.RuntimePermission "*", "setContextClassLoader" in the security policy as "malformed syntax." However:
Analysis from my AI, will understand later on. Adding label to skip for now. |
|
❌ Gradle check result for 2c3187b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
2c3187b to
23be3ac
Compare
PR Reviewer Guide 🔍(Review updated until commit f153367)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to f153367 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 7f96bb9
Suggestions up to commit b05c78d
Suggestions up to commit 58617cc
Suggestions up to commit 2f04074
Suggestions up to commit 483339d
|
23be3ac to
483339d
Compare
|
Persistent review updated to latest commit 483339d |
|
❌ Gradle check result for 483339d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
483339d to
2f04074
Compare
|
Persistent review updated to latest commit 2f04074 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20632 +/- ##
============================================
+ Coverage 73.20% 73.31% +0.10%
- Complexity 72751 73142 +391
============================================
Files 5871 5921 +50
Lines 332688 333644 +956
Branches 48017 48108 +91
============================================
+ Hits 243543 244601 +1058
+ Misses 69625 69470 -155
- Partials 19520 19573 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Persistent review updated to latest commit 58617cc |
58617cc to
b05c78d
Compare
|
Persistent review updated to latest commit b05c78d |
|
❌ Gradle check result for b05c78d: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b05c78d to
7f96bb9
Compare
|
Persistent review updated to latest commit 7f96bb9 |
|
❌ Gradle check result for 7f96bb9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Replace grpc-netty-shaded with unshaded grpc-netty in the transport-grpc module so that both the HTTP transport and gRPC transport share the same io.netty.* classes, enabling Netty handler reuse across transports and eliminating the double Netty runtime memory footprint. - Replace grpc-netty-shaded dependency with grpc-netty and explicit netty dependencies (buffer, codec, codec-base, codec-http, codec-http2, common, handler, resolver, transport, transport-native-unix-common) - Update all imports from io.grpc.netty.shaded.io.grpc.netty.* to io.grpc.netty.* and io.grpc.netty.shaded.io.netty.* to io.netty.* - Update plugin-security.policy to grant permissions to individual unshaded netty jar codebases instead of grpc-netty-shaded - Update thirdPartyAudit ignore lists for unshaded class references - Add netty license/notice/sha1 files, remove shaded sha1 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
7f96bb9 to
f153367
Compare
|
Persistent review updated to latest commit f153367 |
|
❌ Gradle check result for f153367: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Replace grpc-netty-shaded with unshaded grpc-netty in the transport-grpc module so that both the HTTP transport and gRPC transport share the same io.netty.* classes, enabling Netty handler reuse across transports and eliminating the double Netty runtime memory footprint.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.